Bug 44476 - <input type=number>: Support auto-repeat by mouse press
Summary: <input type=number>: Support auto-repeat by mouse press
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 27968
  Show dependency treegraph
 
Reported: 2010-08-23 18:25 PDT by Kent Tamura
Modified: 2010-08-25 02:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.52 KB, patch)
2010-08-23 18:30 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (6.40 KB, patch)
2010-08-25 02:02 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-08-23 18:25:39 PDT
<input type=number>: Support auto-repeat by mouse press
Comment 1 Kent Tamura 2010-08-23 18:30:44 PDT
Created attachment 65197 [details]
Patch
Comment 2 Shinichiro Hamaji 2010-08-25 01:23:54 PDT
Comment on attachment 65197 [details]
Patch

This change looks good, but I think the behavior isn't the best when

1. mouse down on increase button
2. mouse move from increase button to decrease button without mouse up
3. the number will decrease

It seems with windows' standard GUI, the number doesn't change in step 3. I guess this behavior or increasing will be better than the behavior of this patch. I don't have access to Mac for now, could you check what happens on Mac?
Comment 3 Kent Tamura 2010-08-25 01:36:25 PDT
(In reply to comment #2)
> (From update of attachment 65197 [details])
> This change looks good, but I think the behavior isn't the best when
> 
> 1. mouse down on increase button
> 2. mouse move from increase button to decrease button without mouse up
> 3. the number will decrease
> 
> It seems with windows' standard GUI, the number doesn't change in step 3. I guess this behavior or increasing will be better than the behavior of this patch. I don't have access to Mac for now, could you check what happens on Mac?

I agree with you.  I tested the behavior of Mac (SnowLoepard, System Preference -> Date & Time) and found the Mac behavior was the same as this patch :-(
I'll update the patch.
Comment 4 Kent Tamura 2010-08-25 02:02:01 PDT
Created attachment 65385 [details]
Patch 2
Comment 5 Shinichiro Hamaji 2010-08-25 02:16:34 PDT
Comment on attachment 65385 [details]
Patch 2

Looks good. Thanks for checking the behavior of Mac.
Comment 6 Kent Tamura 2010-08-25 02:46:04 PDT
Landed as r66001.