Bug 44471 - [GTK] ScrollbarThemeGtk is incomplete
Summary: [GTK] ScrollbarThemeGtk is incomplete
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2010-08-23 17:29 PDT by Martin Robinson
Modified: 2010-08-26 16:14 PDT (History)
0 users

See Also:

Add theme-based painting for GTK+ scrollbars (28.03 KB, patch)
2010-08-23 17:48 PDT, Martin Robinson
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-08-23 17:29:20 PDT
Currently, interior frame scrollbars are native widgets, which leads to a lot of mysterious code in ScrollbarGtk. It also means that for WebKit2 mouse click need to be routed through GTK+ instead of directly through WebCore. The first step in making fully-fake interior scrollbars is to complete ScrollbarThemeGtk via the Mozilla theming API. The bug tracks that work.
Comment 1 Martin Robinson 2010-08-23 17:48:13 PDT
Created attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars
Comment 2 Gustavo Noronha (kov) 2010-08-26 06:54:24 PDT
Comment on attachment 65191 [details]
Add theme-based painting for GTK+ scrollbars

LGTM. The only thing that looks problematic to me is this:

 56     // We do not support multiple steppers per end yet.
 57     if (part == BackButtonEndPart)
 58         return IntRect();

Though we don't seem to be regressing from our previous state, and thankfully themes sporting more than one button per side seem to have gone out of fashion =).
Comment 3 Martin Robinson 2010-08-26 16:14:33 PDT
Committed r66148: <http://trac.webkit.org/changeset/66148>