Bug 44455 - Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
Summary: Remove references to ArrayBuffer and ArrayBufferView from GraphicsContext3D
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 14:01 PDT by Kenneth Russell
Modified: 2010-08-23 16:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (19.58 KB, patch)
2010-08-23 15:52 PDT, Kenneth Russell
dglazkov: review+
kbr: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-08-23 14:01:47 PDT
The fact that GraphicsContext3D references the ArrayBuffer and ArrayBufferView types makes it difficult to reuse outside of WebGL, and is also a layering violation. GraphicsContext3D should refer only to void* (and a size argument) in these situations.
Comment 1 Kenneth Russell 2010-08-23 15:52:25 PDT
Created attachment 65168 [details]
Patch

From the ChangeLog:

Updated Safari, Qt and Chromium WebGL ports to avoid referencing ArrayBuffer and ArrayBufferView types from GraphicsContext3D. Ran all WebGL layout tests; no new regressions. Built and tested WebKit on Mac OS X; built Chromium on Mac OS X and Linux.
Comment 2 Dimitri Glazkov (Google) 2010-08-23 15:59:37 PDT
Comment on attachment 65168 [details]
Patch

ok.
Comment 3 Kenneth Russell 2010-08-23 16:07:37 PDT
Committed r65839: <http://trac.webkit.org/changeset/65839>