Bug 44448 - Web Inspector: Trace to the style that contributes to the computed styles panel.
Summary: Web Inspector: Trace to the style that contributes to the computed styles panel.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-23 12:11 PDT by Pavel Feldman
Modified: 2010-08-24 11:53 PDT (History)
11 users (show)

See Also:


Attachments
[IMAGE] Looks with the patch applied. (85.60 KB, image/png)
2010-08-23 12:12 PDT, Pavel Feldman
no flags Details
[PATCH] wip patch. (22.50 KB, patch)
2010-08-23 12:14 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[IMAGE] Looks with the patch applied. (69.45 KB, image/png)
2010-08-24 05:51 PDT, Pavel Feldman
no flags Details
[PATCH] Proposed change. (34.55 KB, patch)
2010-08-24 05:52 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Same with one more test expectation fixed. (35.39 KB, patch)
2010-08-24 05:58 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-23 12:11:35 PDT
I am sure I filed a bug for this already, but I can't find it. I'll attach a screenshot with local patch running shortly.
Things to address:
- brush up the looks
- store computed styles tree expansion state
- add disable checkboxes (probably in subsequent patch).
Comment 1 Pavel Feldman 2010-08-23 12:12:10 PDT
Created attachment 65148 [details]
[IMAGE] Looks with the patch applied.
Comment 2 Pavel Feldman 2010-08-23 12:14:27 PDT
Created attachment 65149 [details]
[PATCH] wip patch.
Comment 3 Pavel Feldman 2010-08-24 05:51:43 PDT
Created attachment 65259 [details]
[IMAGE] Looks with the patch applied.
Comment 4 Pavel Feldman 2010-08-24 05:52:47 PDT
Created attachment 65260 [details]
[PATCH] Proposed change.
Comment 5 Pavel Feldman 2010-08-24 05:58:32 PDT
Created attachment 65261 [details]
[PATCH] Same with one more test expectation fixed.
Comment 6 Yury Semikhatsky 2010-08-24 06:27:07 PDT
Comment on attachment 65261 [details]
[PATCH] Same with one more test expectation fixed.

LayoutTests/inspector/elements-tests.js:95
 +      if (!treeItem.listItemElement.textContent.indexOf("width") ||
Please add comment.

LayoutTests/inspector/styles-computed-trace.html:75
 +  Tests that disabling inherited style property does not break further style inspection.
Please fix this.

LayoutTests/inspector/styles-disable-inherited.html:52
 +          testController.notifyDone(testController.results);
You can omit the parameter.

WebCore/inspector/front-end/StylesSidebarPane.js:752
 +          this._contributedProperties = {};
It doesn't seem used, please remove.
Comment 7 Pavel Feldman 2010-08-24 09:16:16 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/inspector/elements-panel-styles-expected.txt
        M       LayoutTests/inspector/elements-tests.js
        A       LayoutTests/inspector/styles-computed-trace-expected.txt
        A       LayoutTests/inspector/styles-computed-trace.html
        M       LayoutTests/inspector/styles-disable-inherited-expected.txt
        M       LayoutTests/inspector/styles-disable-inherited.html
        M       LayoutTests/inspector/styles-disable-then-delete-expected.txt
        M       LayoutTests/inspector/styles-source-lines-inline-expected.txt
        M       LayoutTests/platform/chromium/test_expectations.txt
        M       WebCore/ChangeLog
        M       WebCore/English.lproj/localizedStrings.js
        M       WebCore/inspector/front-end/Section.js
        M       WebCore/inspector/front-end/StylesSidebarPane.js
        M       WebCore/inspector/front-end/inspector.css
        M       WebCore/inspector/front-end/inspector.js
Committed r65905
Comment 8 WebKit Review Bot 2010-08-24 10:03:25 PDT
http://trac.webkit.org/changeset/65905 might have broken GTK Linux 32-bit Release and Qt Linux Release
Comment 9 Adam Barth 2010-08-24 11:44:56 PDT
(In reply to comment #8)
> http://trac.webkit.org/changeset/65905 might have broken GTK Linux 32-bit Release and Qt Linux Release

Anyone looking at this failure?

http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r65905%20(19201)/inspector/styles-computed-trace-pretty-diff.html
Comment 10 Pavel Feldman 2010-08-24 11:48:54 PDT
It is fixed in r65909.
Comment 11 Adam Barth 2010-08-24 11:53:04 PDT
(In reply to comment #10)
> It is fixed in r65909.

Thanks.  I was probably look at a bot that was behind.