I am sure I filed a bug for this already, but I can't find it. I'll attach a screenshot with local patch running shortly. Things to address: - brush up the looks - store computed styles tree expansion state - add disable checkboxes (probably in subsequent patch).
Created attachment 65148 [details] [IMAGE] Looks with the patch applied.
Created attachment 65149 [details] [PATCH] wip patch.
Created attachment 65259 [details] [IMAGE] Looks with the patch applied.
Created attachment 65260 [details] [PATCH] Proposed change.
Created attachment 65261 [details] [PATCH] Same with one more test expectation fixed.
Comment on attachment 65261 [details] [PATCH] Same with one more test expectation fixed. LayoutTests/inspector/elements-tests.js:95 + if (!treeItem.listItemElement.textContent.indexOf("width") || Please add comment. LayoutTests/inspector/styles-computed-trace.html:75 + Tests that disabling inherited style property does not break further style inspection. Please fix this. LayoutTests/inspector/styles-disable-inherited.html:52 + testController.notifyDone(testController.results); You can omit the parameter. WebCore/inspector/front-end/StylesSidebarPane.js:752 + this._contributedProperties = {}; It doesn't seem used, please remove.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/inspector/elements-panel-styles-expected.txt M LayoutTests/inspector/elements-tests.js A LayoutTests/inspector/styles-computed-trace-expected.txt A LayoutTests/inspector/styles-computed-trace.html M LayoutTests/inspector/styles-disable-inherited-expected.txt M LayoutTests/inspector/styles-disable-inherited.html M LayoutTests/inspector/styles-disable-then-delete-expected.txt M LayoutTests/inspector/styles-source-lines-inline-expected.txt M LayoutTests/platform/chromium/test_expectations.txt M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/front-end/Section.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.css M WebCore/inspector/front-end/inspector.js Committed r65905
http://trac.webkit.org/changeset/65905 might have broken GTK Linux 32-bit Release and Qt Linux Release
(In reply to comment #8) > http://trac.webkit.org/changeset/65905 might have broken GTK Linux 32-bit Release and Qt Linux Release Anyone looking at this failure? http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r65905%20(19201)/inspector/styles-computed-trace-pretty-diff.html
It is fixed in r65909.
(In reply to comment #10) > It is fixed in r65909. Thanks. I was probably look at a bot that was behind.