Bug 44428 - Get basic in-process windowed plugins working in WebKit2 on Windows
Summary: Get basic in-process windowed plugins working in WebKit2 on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
Keywords: InRadar, PlatformOnly
Depends on: 46409 46470 46502 46510 46512
  Show dependency treegraph
Reported: 2010-08-23 08:34 PDT by Adam Roben (:aroben)
Modified: 2010-09-24 15:15 PDT (History)
3 users (show)

See Also:

Patch (10.43 KB, patch)
2010-09-24 14:56 PDT, Adam Roben (:aroben)
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-08-23 08:34:42 PDT
This is an umbrella bug for tracking progress on getting in-process windowed plugins working in WebKit2 on Windows (windowless plugins were covered by bug 43189). Once we're able to play some simple Flash videos (e.g., on YouTube) we'll close this bug out.
Comment 1 Adam Roben (:aroben) 2010-08-23 08:35:51 PDT
Comment 2 Adam Roben (:aroben) 2010-09-24 14:56:08 PDT
Created attachment 68758 [details]
Comment 3 Adam Roben (:aroben) 2010-09-24 15:00:33 PDT
Comment on attachment 68758 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=68758&action=review

> WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp:374
>  {
>      ASSERT(m_isStarted);
> +    platformDestroy();
> +
>      // Stop all streams.
>      stopAllStreams();

After talking with Anders, I'm going to move the call to platformDestroy() after the call to NPP_Destroy. That matches what WebKit1 did.
Comment 4 Adam Roben (:aroben) 2010-09-24 15:15:22 PDT
Committed r68299: <http://trac.webkit.org/changeset/68299>