Bug 44426 – [Images] Fix related to image down sampling in cairo port

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Images

[Karol Kosacki]

As can be seen on www.ask.com when using Cairo port, the images are shown incorrectly. Ask.com uses a specific way of showing images - each image is in fact a part of a single large one - appropriate part is shown using absolute positioning. In cairo, positioning of the big image was broken due to down sampling. I ported some code from OpenVG (from ImageOpenVG.cpp) - adjusting source rectangle when down sampling is used. Most part (related to adjustSourceRectForDownSampling function) is just copied, small adjustment to call have been made. I will provide the fix shortly.

[Karol Kosacki]

Created attachment 65122 [details]
Proposed solution to the problem.

[Gyuyoung Kim]

Please request review and cq in order to get review.

[WebKit Review Bot]

Attachment 65122 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Karol Kosacki]

Created attachment 65234 [details]
Proposed solution

[Adam Barth]

Comment on attachment 65234 [details]
Proposed solution

Is there some reason we can't make a test for this patch?  We either need a test or an explanation about why we can't make one.

> WebCore/ChangeLog:10
> +        No new tests. (OOPS!)
This will prevent this patch from landing.

> WebCore/platform/graphics/cairo/ImageCairo.cpp:94
> +static void adjustSourceRectForDownSampling(FloatRect& srcRect, const IntSize& origSize, const IntSize& scaledSize)
origSize => originalSize?

[Leandro Pereira]

No response in a while. Closing bug as WONTFIX; please reopen if needed.