Bug 44423 – Password manager suggestion for WebCore

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Grzegorz Czajkowski]

This patch allows to grab user name and password when user has clicked submit button.
I would like to know your opinion about it.

[Grzegorz Czajkowski]

Created attachment 65119 [details]
Password manager - suggestion for WebCore

[Gyuyoung Kim]

Please add this bug's title and url to Changelog as below, 


2010-08-22  Rafael Antognolli  <[e-mail]>
  2 
  3         Reviewed by Antonio Gomes.
  4 
  5         [EFL] Remove duplicated include entry from default theme.
  6         https://bugs.webkit.org/show_bug.cgi?id=44345
  7 
  8         This used to create the group webkit/widget/entry twice in
  9         the theme. It's leading to a bug with the newer versions of
 10         EFL.
 11 
 12         * DefaultTheme/default.edc:

[Grzegorz Czajkowski]

Created attachment 65377 [details]
Password manager - suggestion for WebCore

[Grzegorz Czajkowski]

Created attachment 65379 [details]
Password manager - suggestion for WebCore

[Rafael Antognolli]

(In reply to comment #4)
> Created an attachment (id=65379) [details]
> Password manager - suggestion for WebCore

Adding some reviewers that did most of the work on this function.

I would also suggest that you should use the PassRefPtr on this PersonalData, and have a method create() on it instead of the default constructor, but not sure about that.

[Darin Adler]

Comment on attachment 65379 [details]
Password manager - suggestion for WebCore

Please don't add this to WebKit. This is the type of behavior that belongs in applications using WebKit, not WebKit itself, and WebKit already provides convenient hooks to make this possible. As proof of concept, both Safari and Chrome implement this type of feature.

[Grzegorz Czajkowski]

(In reply to comment #6)
> (From update of attachment 65379 [details])
> Please don't add this to WebKit. This is the type of behavior that belongs in applications using WebKit, not WebKit itself, and WebKit already provides convenient hooks to make this possible. As proof of concept, both Safari and Chrome implement this type of feature.

What is a finall decission about this patch?
As you can see the patch blocks 44496. Is there any chance to put this patch into WebKit? If not please give me an advise how I can customize it (or patch for WebKit-Efl) to a present password manager of WebKit.
Thank you.

[Darin Adler]

(In reply to comment #7)
> (In reply to comment #6)
> > Please don't add this to WebKit. This is the type of behavior that belongs in applications using WebKit, not WebKit itself, and WebKit already provides convenient hooks to make this possible. As proof of concept, both Safari and Chrome implement this type of feature.
> 
> What is a finall decission about this patch?

My above comment is final as far as I’m concerned.

> As you can see the patch blocks 44496. Is there any chance to put this patch into WebKit? If not please give me an advise how I can customize it (or patch for WebKit-Efl) to a present password manager of WebKit.

Putting a “password manager” into WebKit is not appropriate. Instead this should be built into applications using WebKit as has been done in the past. Perhaps WebKit-EFL does not yet provide the appropriate hooks, and if so, then feel free to work with the maintainers of the WebKit-EFL API to add those hooks.

[Alexey Proskuryakov]

Marking WONTFIX to close the loop.