WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44387
Add the blob URL member to FormData
https://bugs.webkit.org/show_bug.cgi?id=44387
Summary
Add the blob URL member to FormData
Jian Li
Reported
2010-08-21 18:44:42 PDT
When we add a blob into the FormData in out BlobData model, we're adding the blob URL. We need to add the blob URL member to FormDataElement.
Attachments
Proposed Patch
(8.22 KB, patch)
2010-08-21 18:52 PDT
,
Jian Li
jianli
: commit-queue-
Details
Formatted Diff
Diff
Proposed Patch
(8.21 KB, patch)
2010-08-21 19:32 PDT
,
Jian Li
fishd
: review+
jianli
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jian Li
Comment 1
2010-08-21 18:52:33 PDT
Created
attachment 65040
[details]
Proposed Patch
WebKit Review Bot
Comment 2
2010-08-21 18:54:38 PDT
Attachment 65040
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/network/FormData.h:79: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jian Li
Comment 3
2010-08-21 19:32:02 PDT
Created
attachment 65044
[details]
Proposed Patch Fix style error.
Darin Fisher (:fishd, Google)
Comment 4
2010-08-21 21:02:22 PDT
Comment on
attachment 65044
[details]
Proposed Patch WebKit/chromium/src/WebHTTPBody.cpp:80 + result.fileStart = 0; nit: these fields exist regardless of whether or not ENABLE(BLOB) is defined, so they probably should be initialized even when ENABLE(BLOB) is not defined. otherwise, LG R=me
Jian Li
Comment 5
2010-08-22 14:38:22 PDT
Committed as
http://trac.webkit.org/changeset/65786
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug