WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44373
WebKit does not build with Python 2.3
https://bugs.webkit.org/show_bug.cgi?id=44373
Summary
WebKit does not build with Python 2.3
Benjamin Poulain
Reported
2010-08-20 19:45:35 PDT
The patch of
https://bugs.webkit.org/show_bug.cgi?id=43949
introduce a python script in the build system to create html entities. This script requires Python 2.4 because of the function sorted(). This is quite annoying since Scratchbox (for Maemo for example) and older Macs have Python 2.3.
Attachments
Replace the call to sorted() by List::sort()
(1.29 KB, patch)
2010-08-20 19:50 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2010-08-20 19:50:57 PDT
Created
attachment 65017
[details]
Replace the call to sorted() by List::sort() This simple change makes it possible to compile for Maemo 5 again.
WebKit Commit Bot
Comment 2
2010-08-20 20:35:14 PDT
Comment on
attachment 65017
[details]
Replace the call to sorted() by List::sort() Rejecting patch 65017 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20893 test cases. animations/suspend-resume-animation.html -> failed Exiting early after 1 failures. 127 tests run. 32.78s total testing time 126 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output:
http://queues.webkit.org/results/3723404
Andreas Kling
Comment 3
2010-08-20 20:39:19 PDT
Comment on
attachment 65017
[details]
Replace the call to sorted() by List::sort() Clearing flags on attachment: 65017 Committed
r65773
: <
http://trac.webkit.org/changeset/65773
>
Andreas Kling
Comment 4
2010-08-20 20:39:29 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 5
2010-08-21 07:38:05 PDT
Thanks. It's kinda sad, since we require python 2.5 to run the tests. However we made a special exception for Apple's Tiger bot to support 2.3 for building. What platform do you have which still uses Python 2.3? It's ancient! (Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on. I just happened to see this since I get the commit-bot email, but Adam wrote this code.) Thanks for the fix. :)
Adam Barth
Comment 6
2010-08-21 10:11:14 PDT
Without a way to test this on the buildbot, we're going to keep regressing this whenever we touch this script.
Benjamin Poulain
Comment 7
2010-08-21 10:23:15 PDT
(In reply to
comment #5
)
> What platform do you have which still uses Python 2.3? It's ancient!
Yep. Maemo itself uses Python 2.5+, but the build system still uses Python 2.3. We also support Mac OS X Tiger in the Tier 2 platforms of Qt 4.6.
> (Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on. I just happened to see this since I get the commit-bot email, but Adam wrote this code.)
Sorry. I thought that was not necessary given how trivial the fix is.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug