Bug 44370 - Media engine should not be asked to open all urls
Summary: Media engine should not be asked to open all urls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media Elements (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks: 51249
  Show dependency treegraph
 
Reported: 2010-08-20 16:35 PDT by Eric Carlson
Modified: 2011-01-24 12:20 PST (History)
1 user (show)

See Also:


Attachments
proposed patch (6.65 KB, patch)
2010-08-20 16:46 PDT, Eric Carlson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-08-20 16:35:45 PDT
MediaPlayer::load() currently tries to find a media engine that supports the specified MIME type, if there is one, but it uses the first registered engine if none claims the type so the media engine can sniff the data (if it wishes) and handle misconfigured servers. 

This is reasonable in the case where no type is specified in the markup, but it should not ask a media engine to open a url if the markup has a type attribute, and canPlayType() would return "" for that type.
Comment 1 Eric Carlson 2010-08-20 16:46:22 PDT
Created attachment 65010 [details]
proposed patch
Comment 2 Eric Carlson 2010-08-21 11:43:20 PDT
http://trac.webkit.org/changeset/65779
Comment 3 Ademar Reis 2011-01-24 12:20:46 PST
Revision r65779 cherry-picked into qtwebkit-2.2 with commit 0386972 <http://gitorious.org/webkit/qtwebkit/commit/0386972>