Bug 44363 – Add tests for FileWriter

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Eric U.]

Add layout tests for the FileWriter DOM object.

[Eric U.]

Created attachment 76269 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 76269 [details]
Patch

Rejecting attachment 76269 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
esystem/workers/file-writer-events.html
patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html
patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html
patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html
patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7909691

[Eric U.]

The CQ's output actually doesn't show any indication of what the problem might be.  I'm going to upload an updated patch [svn update, fix up changelog, re-upload] and see how that goes.

[Eric Seidel (no email)]

Yes, unfortunately that's true for when svn-apply fais.  That regressed many months ago and we never fixed it. :(

[Eric U.]

Created attachment 82511 [details]
Second try--same patch, but removed one potential conflict that had already been checked in.

[WebKit Commit Bot]

Comment on attachment 82511 [details]
Second try--same patch, but removed one potential conflict that had already been checked in.

Rejecting attachment 82511 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
.
Processing patch 82511 from bug 44363.
Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2

Parsed 18 diffs from patch file(s).
cp: fast/filesystem/file-writer-gc-blob.html: No such file or directory
Failed to copy fast/filesystem/file-writer-gc-blob.html fast/filesystem/resources/file-writer-gc-blob.js. at /Projects/CommitQueue/Tools/Scripts/svn-apply line 427.

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/7910992

[Eric U.]

Created attachment 82531 [details]
Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify.

[WebKit Commit Bot]

Comment on attachment 82531 [details]
Try #3--corrected malformed patch, caused by svn-create-patch not grokking cp+modify.

Rejecting attachment 82531 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
ile LayoutTests/fast/filesystem/workers/file-writer-events.html
patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob-expected.html
patching file LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html
patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped-expected.html
patching file LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7918054

[Eric U.]

Manually committed r80896: http://trac.webkit.org/changeset/80896.

[WebKit Review Bot]

http://trac.webkit.org/changeset/80904 might have broken Chromium Win Release