Bug 44355 – [chromium] layout test for bug 43992 (scrolling issues when accelerated compositor is enabled)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexey Marinichev]

[chromium] layout test for bug 43992 (scrolling issues when accelerated compositor is enabled)

[Alexey Marinichev]

Created attachment 65001 [details]
Patch

[Alexey Marinichev]

ping

[Adam Barth]

Comment on attachment 65001 [details]
Patch

Won't we need expectations for other ports as well?

> LayoutTests/compositing/checkerboard.html:14
> +                    if (i++ < 2047 / 15)
Crazy

[Alexey Marinichev]

Created attachment 66001 [details]
Patch

[Alexey Marinichev]

This "should" be platform-independent: no text, no scrollbars.

[Alexey Marinichev]

will ping again soon

[Eric Seidel (no email)]

Comment on attachment 66001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66001&action=review

> LayoutTests/compositing/checkerboard.html:16
> +                        setTimeout(inner, 10);

Why not setTimeout(inner, 0)?  That will run as fast as possible.

[Alexey Marinichev]

I wanted to actually see stuff happening, with scrollbars absent it could be more difficult.

I will change it to zero in the final version.

[David Levin]

(In reply to comment #8)
> I wanted to actually see stuff happening, with scrollbars absent it could be more difficult.
> 
> I will change it to zero in the final version.
You're asking for review and cq? so this is the final version that will be checked in.

[David Levin]

btw, I don't understand this comment at all:
  14                     // crazy

[Alexey Marinichev]

Yeah, me neither.  It's from comment #3.

[Alexey Marinichev]

Created attachment 68953 [details]
changed timeout to 0

[WebKit Commit Bot]

Comment on attachment 68953 [details]
changed timeout to 0

Clearing flags on attachment: 68953

Committed r68441: <http://trac.webkit.org/changeset/68441>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.