Bug 44355 - [chromium] layout test for bug 43992 (scrolling issues when accelerated compositor is enabled)
Summary: [chromium] layout test for bug 43992 (scrolling issues when accelerated compo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-20 14:21 PDT by Alexey Marinichev
Modified: 2010-09-27 16:28 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.15 KB, patch)
2010-08-20 15:30 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff
Patch (3.64 KB, patch)
2010-08-30 19:16 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff
changed timeout to 0 (3.64 KB, patch)
2010-09-27 14:04 PDT, Alexey Marinichev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Marinichev 2010-08-20 14:21:37 PDT
[chromium] layout test for bug 43992 (scrolling issues when accelerated compositor is enabled)
Comment 1 Alexey Marinichev 2010-08-20 15:30:37 PDT
Created attachment 65001 [details]
Patch
Comment 2 Alexey Marinichev 2010-08-30 12:57:29 PDT
ping
Comment 3 Adam Barth 2010-08-30 16:42:10 PDT
Comment on attachment 65001 [details]
Patch

Won't we need expectations for other ports as well?

> LayoutTests/compositing/checkerboard.html:14
> +                    if (i++ < 2047 / 15)
Crazy
Comment 4 Alexey Marinichev 2010-08-30 19:16:11 PDT
Created attachment 66001 [details]
Patch
Comment 5 Alexey Marinichev 2010-08-30 19:20:21 PDT
This "should" be platform-independent: no text, no scrollbars.
Comment 6 Alexey Marinichev 2010-09-03 16:12:29 PDT
will ping again soon
Comment 7 Eric Seidel (no email) 2010-09-26 10:14:37 PDT
Comment on attachment 66001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=66001&action=review

> LayoutTests/compositing/checkerboard.html:16
> +                        setTimeout(inner, 10);

Why not setTimeout(inner, 0)?  That will run as fast as possible.
Comment 8 Alexey Marinichev 2010-09-27 10:33:35 PDT
I wanted to actually see stuff happening, with scrollbars absent it could be more difficult.

I will change it to zero in the final version.
Comment 9 David Levin 2010-09-27 10:41:36 PDT
(In reply to comment #8)
> I wanted to actually see stuff happening, with scrollbars absent it could be more difficult.
> 
> I will change it to zero in the final version.
You're asking for review and cq? so this is the final version that will be checked in.
Comment 10 David Levin 2010-09-27 10:42:50 PDT
btw, I don't understand this comment at all:
  14                     // crazy
Comment 11 Alexey Marinichev 2010-09-27 10:45:29 PDT
Yeah, me neither.  It's from comment #3.
Comment 12 Alexey Marinichev 2010-09-27 14:04:48 PDT
Created attachment 68953 [details]
changed timeout to 0
Comment 13 WebKit Commit Bot 2010-09-27 16:28:33 PDT
Comment on attachment 68953 [details]
changed timeout to 0

Clearing flags on attachment: 68953

Committed r68441: <http://trac.webkit.org/changeset/68441>
Comment 14 WebKit Commit Bot 2010-09-27 16:28:39 PDT
All reviewed patches have been landed.  Closing bug.