WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44353
Do Not Copy Subversion Related Files in Inspector Build Phase
https://bugs.webkit.org/show_bug.cgi?id=44353
Summary
Do Not Copy Subversion Related Files in Inspector Build Phase
Joseph Pecoraro
Reported
2010-08-20 13:57:25 PDT
`ditto` does a dumb copy in the "Copy Inspector Resources" build phase. Let me know if you think I should switch over to an `rsync --exclude` implementation like the "Copy Forwarding and ICU Headers" build phase.
Attachments
[PATCH] Remove .svn directories
(2.52 KB, patch)
2010-08-20 13:59 PDT
,
Joseph Pecoraro
ddkilzer
: review+
Details
Formatted Diff
Diff
[SCRIPT] Build Phase - Not One Line
(798 bytes, text/plain)
2010-08-20 14:00 PDT
,
Joseph Pecoraro
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2010-08-20 13:59:32 PDT
Created
attachment 64990
[details]
[PATCH] Remove .svn directories Adds the following: # Remove any .svn directories that may have been copied over. find "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector" -name ".svn" -type d | xargs rm -r
Joseph Pecoraro
Comment 2
2010-08-20 14:00:22 PDT
Created
attachment 64991
[details]
[SCRIPT] Build Phase - Not One Line This is what the Build Phase looks like, not in one line.
David Kilzer (:ddkilzer)
Comment 3
2010-08-20 14:06:52 PDT
Comment on
attachment 64990
[details]
[PATCH] Remove .svn directories WebCore/WebCore.xcodeproj/project.pbxproj:20491 + [...]find \"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\" -name \".svn\" -type d | xargs rm -r\n"; I would actually use "rm -rf" here to force the deletion (unless you want the script to complain if rm doesn't work). r=me either way.
Joseph Pecoraro
Comment 4
2010-08-20 14:17:44 PDT
> I would actually use "rm -rf" here [...]
Done. Each of the other `rm -rf` Committed
r65753
M WebCore/ChangeLog M WebCore/WebCore.xcodeproj/project.pbxproj
r65753
= 75779b62fce9cf44123d6ace17d73db0d307f98a (refs/remotes/trunk)
http://trac.webkit.org/changeset/65753
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug