Bug 44353 - Do Not Copy Subversion Related Files in Inspector Build Phase
Summary: Do Not Copy Subversion Related Files in Inspector Build Phase
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-08-20 13:57 PDT by Joseph Pecoraro
Modified: 2010-08-20 14:17 PDT (History)
3 users (show)

See Also:

[PATCH] Remove .svn directories (2.52 KB, patch)
2010-08-20 13:59 PDT, Joseph Pecoraro
ddkilzer: review+
Details | Formatted Diff | Diff
[SCRIPT] Build Phase - Not One Line (798 bytes, text/plain)
2010-08-20 14:00 PDT, Joseph Pecoraro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-08-20 13:57:25 PDT
`ditto` does a dumb copy in the "Copy Inspector Resources" build phase.
Let me know if you think I should switch over to an `rsync --exclude`
implementation like the "Copy Forwarding and ICU Headers" build phase.
Comment 1 Joseph Pecoraro 2010-08-20 13:59:32 PDT
Created attachment 64990 [details]
[PATCH] Remove .svn directories

Adds the following:

    # Remove any .svn directories that may have been copied over.
    find "${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector" -name ".svn" -type d | xargs rm -r
Comment 2 Joseph Pecoraro 2010-08-20 14:00:22 PDT
Created attachment 64991 [details]
[SCRIPT] Build Phase - Not One Line

This is what the Build Phase looks like, not in one line.
Comment 3 David Kilzer (:ddkilzer) 2010-08-20 14:06:52 PDT
Comment on attachment 64990 [details]
[PATCH] Remove .svn directories

+ [...]find \"${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\" -name \".svn\" -type d | xargs rm -r\n";

I would actually use "rm -rf" here to force the deletion (unless you want the script to complain if rm doesn't work).

r=me either way.
Comment 4 Joseph Pecoraro 2010-08-20 14:17:44 PDT
> I would actually use "rm -rf" here [...]

Done. Each of the other `rm -rf`

Committed r65753
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
r65753 = 75779b62fce9cf44123d6ace17d73db0d307f98a (refs/remotes/trunk)