Bug 44330 – [Qt] WebKit2 needs to support touchevents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Juha Savolainen]

[Qt] WebKit2 needs to support QTouchEvents.

[Juha Savolainen]

Created attachment 64942 [details]
This patch adds QTouchvents-support for webkit2-qt

[Kenneth Rohde Christiansen]

Comment on attachment 64942 [details]
This patch adds QTouchvents-support for webkit2-qt

WebKit2/ChangeLog:6
 +          https://bugs.webkit.org/show_bug.cgi?id=44330
The ChangeLog could be a bit more descriptive about what you did, like why and how.

WebKit2/Shared/WebEvent.h:57
 +         , TouchMove
The , should be last. The first one is acceptable only due to it not compiling without and I might even add that on a separate line

WebKit2/Shared/WebEvent.h:409
 +      Type type() const { return (Type)m_type; }
Why not use a C++ cast instead?

WebKit2/Shared/WebEvent.h:418
 +      static bool decode(CoreIPC::ArgumentDecoder* decoder, WebTouchEvent& t)
I think "ev" or "event" makes more sense than t

WebKit2/Shared/WebEvent.h:426
 +      return true;
indentation issue here

WebKit2/Shared/WebEvent.h:442
 +  
additional newline, remove

WebKit2/Shared/WebEventConversion.cpp:157
 +      WebKit2PlatformTouchPoint(const WebTouchPoint& webTouchPoint)
The contents of this method has wrong indentation

WebKit2/Shared/WebEventConversion.cpp:157
 +      WebKit2PlatformTouchPoint(const WebTouchPoint& webTouchPoint)
Maybe this class should be called WebPlatformTouchPoint for consistency reasons?

WebKit2/Shared/WebEventConversion.cpp:183
 +  
extra newline, remove

WebKit2/Shared/WebEventConversion.cpp:185
 +  
here as well

WebKit2/Shared/WebEventConversion.cpp:192
 +  
here as well plus the whole method has wrong indentation

WebKit2/Shared/qt/WebEventFactoryQt.cpp:187
 +          case Qt::TouchPointReleased: state = WebTouchPoint::TouchReleased; break;
wrong coding style!

WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:153
 +                  || event->type() == QEvent::TouchEnd
wrong coding style

WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:152
 +      if ( event->type() == QEvent::TouchBegin
wrong coding style

[Juha Savolainen]

(In reply to comment #2)
> (From update of attachment 64942 [details])

> WebKit2/Shared/WebEvent.h:409
>  +      Type type() const { return (Type)m_type; }
> Why not use a C++ cast instead?

We remove this because we can use function from base-class.

> WebKit2/Shared/WebEvent.h:418
>  +      static bool decode(CoreIPC::ArgumentDecoder* decoder, WebTouchEvent& t)
> I think "ev" or "event" makes more sense than t

This function is inherited from WebEvent and also all other WebEventXXX-classes has named parameters in the same way.

[Juha Savolainen]

Created attachment 64948 [details]
Fixed version(review comments)

[Kenneth Rohde Christiansen]

Comment on attachment 64948 [details]
Fixed version(review comments)

WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:153
 +             || event->type() == QEvent::TouchEnd
This indentation here wasnt fixed

WebKit2/UIProcess/API/qt/qgraphicswkview.h:69
 +      virtual void touchEvent(QTouchEvent* ev);
remove ev here

R=me, with the above changes.

[Juha Savolainen]

Created attachment 65023 [details]
Fixed patch

[WebKit Commit Bot]

Comment on attachment 65023 [details]
Fixed patch

Clearing flags on attachment: 65023

Committed r65788: <http://trac.webkit.org/changeset/65788>