Bug 44327 - Web Inspector: remove javascript breakpoint specific code from BreakpointSidebarPane
Summary: Web Inspector: remove javascript breakpoint specific code from BreakpointSide...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-20 02:17 PDT by Pavel Podivilov
Modified: 2010-08-23 07:41 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch. (16.56 KB, patch)
2010-08-20 02:46 PDT, Pavel Podivilov
pfeldman: review-
Details | Formatted Diff | Diff
Proposed patch. (16.55 KB, patch)
2010-08-20 06:58 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2010-08-20 02:17:34 PDT
Web Inspector: remove breakpoint specific code from BreakpointSidebarPane
Comment 1 Pavel Podivilov 2010-08-20 02:46:16 PDT
Created attachment 64939 [details]
Proposed patch.
Comment 2 Pavel Feldman 2010-08-20 05:07:34 PDT
Comment on attachment 64939 [details]
Proposed patch.

WebCore/inspector/front-end/BreakpointsSidebarPane.js:86
 +  WebInspector.BreakpointElement = function(breakpoint)
Please rename WebInspector.BreakpointElement => WebInspector.JSBreakpointItem. Otherwise looks good.
Comment 3 Pavel Podivilov 2010-08-20 06:58:30 PDT
Created attachment 64953 [details]
Proposed patch.
Comment 4 WebKit Commit Bot 2010-08-23 07:41:24 PDT
Comment on attachment 64953 [details]
Proposed patch.

Clearing flags on attachment: 64953

Committed r65810: <http://trac.webkit.org/changeset/65810>
Comment 5 WebKit Commit Bot 2010-08-23 07:41:29 PDT
All reviewed patches have been landed.  Closing bug.