Bug 44315 – HISTORY_ALWAYS_ASYNC should be removed (history should always be async)

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[Mihai Parparita]

It looks like the HISTORY_ALWAYS_ASYNC #define was added for bug 33538. At that point there was some debate as to the intent of the HTML5 spec. However, it looks like there was a WHATWG thread to discuss this (http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2010-January/thread.html#24786) and the outcome was that the spec now says "To traverse the history by a delta delta, the user agent must queue a task to run the following steps. " (from http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history-by-a-delta)

Brady, I realize that you were opposed to this change initially. Given that the spec has been updated (as as far as I can tell, no existing layout tests depend on navigation being synchronous), would you be OK with it now?

[Mihai Parparita]

Created attachment 65319 [details]
Patch

[Mihai Parparita]

Comment on attachment 65319 [details]
Patch

Actually, fast/dom/location-hash.html fails with this change. I'll need to update that too.

[Brady Eidson]

Wonder what the change to that test will be.

[Mihai Parparita]

Created attachment 65328 [details]
Patch

[Mihai Parparita]

(In reply to comment #3)
> Wonder what the change to that test will be.

It's basically reverting the changes to the test made by r53950. With my changes the test won't pass if traversal is synchronous, if you'd like I can make it pass with either sync or async traversal (since there's an separatel explicit test for async behavior).

[Adam Barth]

Comment on attachment 65328 [details]
Patch

Following HTML5 is a good idea.  Brady, feel free to let us know if you're still opposed to this patch.

[WebKit Commit Bot]

Comment on attachment 65328 [details]
Patch

Clearing flags on attachment: 65328

Committed r66458: <http://trac.webkit.org/changeset/66458>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.