Bug 44294 - After r65681, caret no longer displays promptly while editing form fields
Summary: After r65681, caret no longer displays promptly while editing form fields
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
Keywords: InRadar
Depends on: 21834
Blocks: 44290
  Show dependency treegraph
Reported: 2010-08-19 14:39 PDT by Simon Fraser (smfr)
Modified: 2010-09-16 12:42 PDT (History)
4 users (show)

See Also:

Patch (1.67 KB, patch)
2010-08-20 14:46 PDT, Simon Fraser (smfr)
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-08-19 14:39:14 PDT
r65681 caused the caret to use the last-computed caret rect when painting, rather than forcing a style update. That seems to have changed the drawing of the caret in the middle of editing. This testcase shows a pixel difference as a result:

Comment 1 Simon Fraser (smfr) 2010-08-19 15:03:53 PDT
Hmm, this only seems to be when you hit the end of the field and start to scroll.
Comment 2 Simon Fraser (smfr) 2010-08-20 09:53:36 PDT
Comment 3 Simon Fraser (smfr) 2010-08-20 14:46:42 PDT
Created attachment 64995 [details]
Comment 4 Enrica Casucci 2010-08-23 08:50:38 PDT
This looks good to me.
Comment 5 Simon Fraser (smfr) 2010-08-24 14:02:10 PDT
Comment 6 WebKit Review Bot 2010-08-24 14:46:46 PDT
http://trac.webkit.org/changeset/65934 might have broken Leopard Intel Release (Tests)
The following changes are on the blame list: