Bug 44273 - Web Inspector: fall back to object formatting in case dom is not yet loaded.
Summary: Web Inspector: fall back to object formatting in case dom is not yet loaded.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 10:30 PDT by Pavel Feldman
Modified: 2010-12-20 23:25 PST (History)
9 users (show)

See Also:


Attachments
[PATCH] Proposed change. (2.54 KB, patch)
2010-08-19 10:32 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[PATCH] Proposed change. (1.96 KB, patch)
2010-08-19 10:34 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-19 10:30:59 PDT
Sometimes DOM is loaded after the inline message is being formatted, so we get no nodeId for it. Let us fall back to object formatting in such cases.
Patch to follow.
Comment 1 Pavel Feldman 2010-08-19 10:32:53 PDT
Created attachment 64868 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2010-08-19 10:34:26 PDT
Comment on attachment 64868 [details]
[PATCH] Proposed change.

WebCore/ChangeLog:10
 +          Patch to follow.
Remove this from changelog.

WebCore/inspector/front-end/ConsoleView.js:663
 +  console.log(JSON.stringify(parameters));
Remove this as well.
Comment 3 Pavel Feldman 2010-08-19 10:34:40 PDT
Created attachment 64869 [details]
[PATCH] Proposed change.
Comment 4 Eric Seidel (no email) 2010-12-20 22:30:42 PST
Comment on attachment 64869 [details]
[PATCH] Proposed change.

Looks abandoned.  Maybe it never got committed?
Comment 5 WebKit Commit Bot 2010-12-20 23:25:42 PST
Comment on attachment 64869 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 64869

Committed r74399: <http://trac.webkit.org/changeset/74399>
Comment 6 WebKit Commit Bot 2010-12-20 23:25:48 PST
All reviewed patches have been landed.  Closing bug.