Bug 44264 - Remove IDBDatabase.description per spec changes
Summary: Remove IDBDatabase.description per spec changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 07:49 PDT by Jeremy Orlow
Modified: 2010-08-23 06:23 PDT (History)
3 users (show)

See Also:


Attachments
Patch (16.36 KB, patch)
2010-08-19 07:52 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (16.00 KB, patch)
2010-08-23 04:54 PDT, Jeremy Orlow
steveblock: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2010-08-19 07:49:18 PDT
Remove IDBDatabase.description per spec changes
Comment 1 Jeremy Orlow 2010-08-19 07:52:58 PDT
Created attachment 64852 [details]
Patch
Comment 2 Steve Block 2010-08-23 03:17:18 PDT
Comment on attachment 64852 [details]
Patch

WebCore/manual-tests/indexed-database.html:53
 +  function step3()
Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places?
Comment 3 Jeremy Orlow 2010-08-23 04:29:00 PDT
(In reply to comment #2)
> (From update of attachment 64852 [details])
> WebCore/manual-tests/indexed-database.html:53
>  +  function step3()
> Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places?

It is.  I can do that.  Any other comments?
Comment 4 Andrei Popescu 2010-08-23 04:32:41 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 64852 [details] [details])
> > WebCore/manual-tests/indexed-database.html:53
> >  +  function step3()
> > Isn't this the same as step1()? Can't you rename it openExpectSuccess() or similar and re-use it in both places?
> 
> It is.  I can do that.  Any other comments?

LGTM
Comment 5 Jeremy Orlow 2010-08-23 04:54:39 PDT
Created attachment 65102 [details]
Patch
Comment 6 Steve Block 2010-08-23 05:37:44 PDT
Comment on attachment 65102 [details]
Patch

r=me
Comment 7 Jeremy Orlow 2010-08-23 06:23:25 PDT
Committed r65807: <http://trac.webkit.org/changeset/65807>