Bug 44240 - REGRESSION (r62896): Interpreter incorrectly excludes prototype chain when validating put_by_id_transition
Summary: REGRESSION (r62896): Interpreter incorrectly excludes prototype chain when va...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 44241 (view as bug list)
Depends on: 41929
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-19 04:41 PDT by David Kilzer (:ddkilzer)
Modified: 2010-08-24 10:08 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2010-08-23 16:51 PDT, Oliver Hunt 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2010-08-19 04:41:25 PDT 
LayoutTests/fast/js/dictionary-no-cache.html fails using the JSC interpreter, but passes using the JSC JIT.

--- a/LayoutTests/fast/js/dictionary-no-cache-expected.txt
+++ b/LayoutTests/fast/js/dictionary-no-cache-expected.txt
@@ -5,7 +5,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 PASS foundNewPrototypeProperty is true
 PASS foundRemovedPrototypeProperty is false
-PASS calledNewPrototypeSetter is true
+FAIL calledNewPrototypeSetter should be true. Was false.
 PASS getTestProperty(test4) is "on prototype"
 PASS getTestProperty(test4) is "on self"
 PASS getTestProperty(test5) is "on prototype's prototype"
Comment 1 David Kilzer (:ddkilzer) 2010-08-19 04:48:05 PDT 
<rdar://problem/8328995>
Comment 2 Oliver Hunt 2010-08-23 16:32:10 PDT 
*** Bug 44241 has been marked as a duplicate of this bug. ***
Comment 3 Oliver Hunt 2010-08-23 16:51:37 PDT 
Created attachment 65184 [details]
Patch
Comment 4 Darin Adler 2010-08-23 16:54:25 PDT 
Comment on attachment 65184 [details]
Patch

Is there a regression test covering this already?
Comment 5 Oliver Hunt 2010-08-23 17:05:39 PDT 
Committed r65847
Comment 6 David Kilzer (:ddkilzer) 2010-08-23 17:40:37 PDT 
(In reply to comment #4)
> (From update of attachment 65184 [details])
> Is there a regression test covering this already?

Yes, except we don't have any buildbots running tests with the JSC Interpreter:

fast/js/dictionary-no-cache.html
fast/js/pic/cached-prototype-setter.html
Comment 7 David Kilzer (:ddkilzer) 2010-08-24 10:08:04 PDT 
The regression was introduced in r62896 for Bug 41929.
<http://trac.webkit.org/changeset/62896>