Bug 44236 - GTK port doesnt compile with video turned off
Summary: GTK port doesnt compile with video turned off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 02:19 PDT by zaheer
Modified: 2010-08-25 06:08 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (2.12 KB, patch)
2010-08-19 02:39 PDT, zaheer 		xan.lopez: review-
Details | Formatted Diff | Diff
Updated Patch (4.00 KB, patch)
2010-08-21 02:53 PDT, zaheer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zaheer 2010-08-19 02:19:24 PDT 
compilation error in WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp with video turned off. Attaching possible patch.
Comment 1 zaheer 2010-08-19 02:39:51 PDT 
Created attachment 64824 [details]
Proposed patch
Comment 2 Xan Lopez 2010-08-20 01:49:04 PDT 
Comment on attachment 64824 [details]
Proposed patch

This is not enough, you also need to disable the generation of the API files. Check in the main GNUMakefile.am how the geolocation stuff is made conditional.

Also, I think the preferred style for conditional headers is to put them after all the unconditional ones.
Comment 3 zaheer 2010-08-21 02:53:55 PDT 
Created attachment 65024 [details]
Updated Patch
Comment 4 Xan Lopez 2010-08-21 02:57:13 PDT 
Comment on attachment 65024 [details]
Updated Patch

Fantastic, thank you.
Comment 5 zaheer 2010-08-22 22:58:52 PDT 
(In reply to comment #4)
> (From update of attachment 65024 [details])
> Fantastic, thank you.
Thank you. Could you push to the commit queue.
Comment 6 Xan Lopez 2010-08-25 05:17:56 PDT 
Comment on attachment 65024 [details]
Updated Patch

Forgot to set cq+
Comment 7 WebKit Commit Bot 2010-08-25 06:08:50 PDT 
Comment on attachment 65024 [details]
Updated Patch

Clearing flags on attachment: 65024

Committed r66009: <http://trac.webkit.org/changeset/66009>
Comment 8 WebKit Commit Bot 2010-08-25 06:08:55 PDT 
All reviewed patches have been landed.  Closing bug.