We can enable truncated floating point fast cases to speed up several arithmetic tests.
Created attachment 64816 [details]
Enable truncated floating point feature on ARM
SunSpider: 1.011x as fast
V8: 1.003x as fast
WindScorpion: 1.003x as fast
Attachment 64816 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed revision 65993.
(In reply to comment #3)
> Committed revision 65993.
This solution doesn't work for this test case:
alert(largeNeg >>> 5); // wrong when using ARM assembler.
Also see https://bugs.webkit.org/show_bug.cgi?id=67486
Should we revert this commit?
We should fix or revert. Do you have time to look into this Gabor, or would you prefer we just roll out for now?
We should also add the test case to a layout test, if it is not already covered.
(In reply to comment #5)
> We should fix or revert. Do you have time to look into this Gabor, or would you prefer we just roll out for now?
> We should also add the test case to a layout test, if it is not already covered.
I attached a patch to https://bugs.webkit.org/show_bug.cgi?id=67486, which contains a test case. Should I move that patch to here and close 67486?
Hey Yong Li, thanks for the test case, and using a separate bug to track the roll out seems fine to me (this is what the sheriff bot does).
Rolled out by bug #67486
Attachment 64816 [details] was posted by a committer and has review+, assigning to Gabor Loki for commit.
This change was rolled out, looks like this is fixed by bug #67486 , and this change is now dead. Closing as invalid. If this is likely to be resurrected then apologies, and please feel free to reopen this bug.