Bug 44232 - [Qt] Avoid unnecessary string copy in TextCodecQt::decode()
Summary: [Qt] Avoid unnecessary string copy in TextCodecQt::decode()
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: QtWebKit Unassigned
Keywords: Performance, Qt, QtTriaged
Depends on:
Reported: 2010-08-19 00:39 PDT by Andreas Kling
Modified: 2010-08-19 01:16 PDT (History)
0 users

See Also:

Proposed patch (1.24 KB, patch)
2010-08-19 00:41 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-08-19 00:39:30 PDT
The string returned by QTextCodec::toUnicode() is unnecessarily copied before it's appended to the return value.
Comment 1 Andreas Kling 2010-08-19 00:41:52 PDT
Created attachment 64815 [details]
Proposed patch
Comment 2 Andreas Kling 2010-08-19 01:16:10 PDT
Comment on attachment 64815 [details]
Proposed patch

Clearing flags on attachment: 64815

Committed r65659: <http://trac.webkit.org/changeset/65659>
Comment 3 Andreas Kling 2010-08-19 01:16:21 PDT
All reviewed patches have been landed.  Closing bug.