Bug 44224 - Move FileStreamClient to platform and add AsyncFileStream interface
Summary: Move FileStreamClient to platform and add AsyncFileStream interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jian Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 17:35 PDT by Jian Li
Modified: 2010-08-20 11:35 PDT (History)
5 users (show)

See Also:


Attachments
Proposed Patch (23.10 KB, patch)
2010-08-18 17:38 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (23.10 KB, patch)
2010-08-18 17:42 PDT, Jian Li
jianli: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch (23.18 KB, patch)
2010-08-18 18:59 PDT, Jian Li
levin: review+
jianli: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jian Li 2010-08-18 17:35:08 PDT
Move FileStreamClient to platform and add AsyncFileStream interface. This is needed by BlobResounceHandle that is put under platform/network.
Comment 1 Jian Li 2010-08-18 17:38:47 PDT
Created attachment 64794 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2010-08-18 17:40:16 PDT
Attachment 64794 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/AsyncFileStream.h:59:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jian Li 2010-08-18 17:42:15 PDT
Created attachment 64795 [details]
Proposed Patch

Fixed style error.
Comment 4 Jian Li 2010-08-18 18:59:09 PDT
Created attachment 64798 [details]
Proposed Patch
Comment 5 Jian Li 2010-08-20 11:35:29 PDT
Committed as http://trac.webkit.org/changeset/65745.