Bug 44223 – [chromium] Fixing previous Mac only build breakage with TilingDataTest.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Vincent Scheib]

[chromium] Fixing previous Mac only build breakage with TilingDataTest.cpp

[Vincent Scheib]

Created attachment 64793 [details]
Patch

[WebKit Review Bot]

Attachment 64793 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/tests/TilingDataTest.cpp:33:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Levin]

Comment on attachment 64793 [details]
Patch

> diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog
> index 829705e95a9f714ab2c42befa1192a8bb6c5288e..2fa65e8a61d426dd73f4be6b0f91160de715f1dc 100644
> --- a/WebKit/chromium/ChangeLog
> +++ b/WebKit/chromium/ChangeLog
> @@ -1,3 +1,16 @@
> [phone]  Vincent Scheib  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fixing previous Mac only build breakage with TilingDataTest.cpp

Please include a link to the bug.

> +
> +        The test included the wrong header, which had a compile option around the definition of the WebCore namespace. Without the namespace defined, error. Fixed by correctly including TilingData.h, which has no conditional compilation.

The only place that I know of where lines are wrapped is in the ChangeLog.  Please break this line appropriately -- maybe around 80 columns.

> +
> +        Note: Style error is a false positive, since there is no .h file for TilingDataTest.cpp

No need to make a note in the ChangeLog about a stylebot error that is mention in the bug.

btw, that bug is https://bugs.webkit.org/show_bug.cgi?id=39514 if you feel inclined to fix it :)

[Vincent Scheib]

Created attachment 64866 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 64866 [details]
Patch

Rejecting patch 64866 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20876 test cases.
fast/frames/flattening/iframe-flattening-offscreen.html -> failed

Exiting early after 1 failures. 8000 tests run.
259.24s total testing time

7999 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
5 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3776377

[WebKit Commit Bot]

Comment on attachment 64866 [details]
Patch

Clearing flags on attachment: 64866

Committed r65688: <http://trac.webkit.org/changeset/65688>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.