Bug 44218 - run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText tests
Summary: run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.5
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 16:57 PDT by Ryosuke Niwa
Modified: 2017-07-18 08:29 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-18 16:57:50 PDT 
run-webkit-tests's pretty diff currently does not support non-ASCII characters.  As a result, non-ASCII characters such as those used to test RTL texts are corrupted in the expected results when the test uses dumpAsText.  Try editing/text-iterator/rtl-selection-crash.html for example.
Comment 1 Eric Seidel (no email) 2010-08-18 17:34:34 PDT 
FYI: diffs have no encoding and must be treated as binary.
Comment 2 Alexey Proskuryakov 2010-08-20 10:37:35 PDT 
Actually, I think that expected results are always UTF-8.
Comment 3 Adam Klein 2012-10-19 15:15:10 PDT 
Just wasted some time due to this; haven't ever looked at pretty diff, how hard is this to fix?