WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
44218
run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText tests
https://bugs.webkit.org/show_bug.cgi?id=44218
Summary
run-webkit-tests's pretty diff do not support UTF-8 characters on dumpAsText ...
Ryosuke Niwa
Reported
2010-08-18 16:57:50 PDT
run-webkit-tests's pretty diff currently does not support non-ASCII characters. As a result, non-ASCII characters such as those used to test RTL texts are corrupted in the expected results when the test uses dumpAsText. Try editing/text-iterator/rtl-selection-crash.html for example.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-08-18 17:34:34 PDT
FYI: diffs have no encoding and must be treated as binary.
Alexey Proskuryakov
Comment 2
2010-08-20 10:37:35 PDT
Actually, I think that expected results are always UTF-8.
Adam Klein
Comment 3
2012-10-19 15:15:10 PDT
Just wasted some time due to this; haven't ever looked at pretty diff, how hard is this to fix?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug