WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
44215
Add ability to set custom userAgent for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44215
Summary
Add ability to set custom userAgent for WebKit2
Sam Weinig
Reported
2010-08-18 16:29:37 PDT
Add ability to set custom userAgent for WebKit2
Attachments
Patch
(7.68 KB, patch)
2010-08-18 16:30 PDT
,
Sam Weinig
jhoneycutt
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2010-08-18 16:30:30 PDT
Created
attachment 64786
[details]
Patch
Jon Honeycutt
Comment 2
2010-08-18 16:38:22 PDT
Comment on
attachment 64786
[details]
Patch +String WebPage::userAgent()
> +{ > + if (!m_customUserAgent.isNull()) > + return m_customUserAgent; > + > + // FIXME: This should be based on an application name. > + return "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6; en-us) AppleWebKit/531.4 (KHTML, like Gecko) Version/4.0.3 Safari/531.4";
Extra space after return.
> @@ -92,6 +92,7 @@ public: > // -- Called from WebCore clients. > bool handleEditingKeyboardEvent(WebCore::KeyboardEvent*); > void show(); > + String userAgent();
Looks like this could be const. r=me
Sam Weinig
Comment 3
2010-08-18 16:46:35 PDT
Landed in
r65644
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug