Bug 44214 - Naming of methods in GraphicsLayer having to do with Transitions shouldn't have "Animation" in them
Summary: Naming of methods in GraphicsLayer having to do with Transitions shouldn't ha...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 16:28 PDT by Chris Marrin
Modified: 2010-08-18 16:40 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2010-08-18 16:28:22 PDT 
GraphicsLayerCA has a pretty confusing use of the word "Animation" and related concepts. We use the term "BasicAnimation" to mean transitions and "KeyframeAnimation" to mean animations. We also have the term "AnimationsForProperty" to mean transitions and "AnimationsForKeyframes" to mean animations. It would be a lot clearer if we just used the terms "Transition" and "Animation" consistently.
Comment 1 Simon Fraser (smfr) 2010-08-18 16:36:54 PDT 
I think the point was that at the GraphicsLayer level, we didn't really want to distinguish between transitions and animations. Both are just animating a property over time. The only difference is that we need to be able to map a keyframe name to a set of property animations.

We could even move the keyframe->property map up to RenderLayerBacking, perhaps.

So I don't think we should burden GraphicsLayer with knowledge of transitions vs. animations.
Comment 2 Chris Marrin 2010-08-18 16:40:39 PDT 
Sure, I think that's reasonable. The point is that right now it's confusing so it needs some consistency work at some point.