Bug 44205 - [Chromium] Add Full screen item to video context menu
Summary: [Chromium] Add Full screen item to video context menu
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 14:49 PDT by Bo Liu
Modified: 2013-04-09 16:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2010-08-18 14:58 PDT, Bo Liu 		no flags Details | Formatted Diff | Diff
Update comment to FIXME (1.22 KB, patch)
2010-08-19 11:30 PDT, Bo Liu 		abarth: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bo Liu 2010-08-18 14:49:07 PDT 
Corresponding Chromium patch: http://codereview.chromium.org/3124032

Adds a Fullscreen WebMediaPlayerAction.
Comment 1 Bo Liu 2010-08-18 14:58:43 PDT 
Created attachment 64778 [details]
Patch
Comment 2 Andrew Scherkus 2010-08-19 09:46:06 PDT 
Comment on attachment 64778 [details]
Patch

WebKit/chromium/src/WebViewImpl.cpp:1516
 +          // Bring full screen window into focus if isFullscreen.
is this a TODO or leftover comment?
Comment 3 Bo Liu 2010-08-19 09:48:11 PDT 
It's a "Not Implemented"/TODO comment.
Comment 4 Andrew Scherkus 2010-08-19 10:50:21 PDT 
Comment on attachment 64778 [details]
Patch

WebKit/chromium/src/WebViewImpl.cpp:1516
 +          // Bring full screen window into focus if isFullscreen.
ok in which case you should make this a // FIXME: Bring full screen blah blah blah ...
Comment 5 Bo Liu 2010-08-19 11:30:04 PDT 
Created attachment 64879 [details]
Update comment to FIXME
Comment 6 Adam Barth 2010-08-30 16:15:06 PDT 
Comment on attachment 64879 [details]
Update comment to FIXME

This patch is missing a ChangeLog.
Comment 7 Stephen Chenney 2013-04-09 16:09:57 PDT 
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.