Bug 44198 - [Chromium] m_downloadFilePath should be copied in WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors
Summary: [Chromium] m_downloadFilePath should be copied in WebURLRequestPrivateImpl's ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dumitru Daniliuc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 13:17 PDT by Dumitru Daniliuc
Modified: 2010-08-18 16:18 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.73 KB, patch)
2010-08-18 15:00 PDT, Dumitru Daniliuc 		fishd: review+
dumi: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2010-08-18 13:17:24 PDT 
The m_downloadFilePath flag is currently not propagated correctly, because WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors don't copy it. We should fix that.
Comment 1 Dumitru Daniliuc 2010-08-18 15:00:56 PDT 
Created attachment 64779 [details]
patch
Comment 2 Dumitru Daniliuc 2010-08-18 15:47:05 PDT 
landed: r65636.
Comment 3 WebKit Review Bot 2010-08-18 16:18:53 PDT 
http://trac.webkit.org/changeset/65636 might have broken Chromium Mac Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/65635
http://trac.webkit.org/changeset/65636
http://trac.webkit.org/changeset/65637