Bug 44196 - [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor
Summary: [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 12:48 PDT by Nat Duca
Modified: 2010-08-30 21:25 PDT (History)
5 users (show)

See Also:


Attachments
Invalidate view when compositor activates (1.99 KB, patch)
2010-08-18 14:22 PDT, Nat Duca
no flags Details | Formatted Diff | Diff
Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect (1.81 KB, patch)
2010-08-19 14:00 PDT, Nat Duca
no flags Details | Formatted Diff | Diff
Make style bot happy (1.81 KB, patch)
2010-08-19 14:04 PDT, Nat Duca
no flags Details | Formatted Diff | Diff
Trying again. Not my day for patch files, it seems. (1.81 KB, patch)
2010-08-19 15:06 PDT, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nat Duca 2010-08-18 12:48:59 PDT
When compositor activates due to a DOM change, webkit dirties only the rect affected by the change, for example just  the client area but not the scroll bar. This causes the compositor to receive only the client area rather than the complete view, leading to bits of blue where none should be.
Comment 1 Nat Duca 2010-08-18 14:22:37 PDT
Created attachment 64770 [details]
Invalidate view when compositor activates
Comment 2 Nat Duca 2010-08-19 14:00:09 PDT
Created attachment 64896 [details]
Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect
Comment 3 WebKit Review Bot 2010-08-19 14:04:27 PDT
Attachment 64896 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Nat Duca 2010-08-19 14:04:45 PDT
Created attachment 64898 [details]
Make style bot happy
Comment 5 WebKit Review Bot 2010-08-19 14:05:51 PDT
Attachment 64898 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Nat Duca 2010-08-19 15:06:23 PDT
Created attachment 64903 [details]
Trying again. Not my day for patch files, it seems.
Comment 7 Adam Barth 2010-08-30 16:17:50 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Looks reasonable to me, but I'm not an expert in this area.
Comment 8 Vangelis Kokkevis 2010-08-30 16:35:25 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Looks good on my side too. cq+ from me.
Comment 9 WebKit Commit Bot 2010-08-30 17:03:21 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Rejecting patch 64903 from commit-queue.

vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 10 Vangelis Kokkevis 2010-08-30 18:14:35 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

One more try to get it to the commit queue.
Comment 11 Vangelis Kokkevis 2010-08-30 18:15:13 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

with the flag set correctly this time :)
Comment 12 WebKit Commit Bot 2010-08-30 18:18:46 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Rejecting patch 64903 from commit-queue.

vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 13 WebKit Commit Bot 2010-08-30 21:25:18 PDT
Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Clearing flags on attachment: 64903

Committed r66450: <http://trac.webkit.org/changeset/66450>
Comment 14 WebKit Commit Bot 2010-08-30 21:25:23 PDT
All reviewed patches have been landed.  Closing bug.