Bug 44196 – [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nat Duca]

When compositor activates due to a DOM change, webkit dirties only the rect affected by the change, for example just  the client area but not the scroll bar. This causes the compositor to receive only the client area rather than the complete view, leading to bits of blue where none should be.

[Nat Duca]

Created attachment 64770 [details]
Invalidate view when compositor activates

[Nat Duca]

Created attachment 64896 [details]
Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect

[WebKit Review Bot]

Attachment 64896 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nat Duca]

Created attachment 64898 [details]
Make style bot happy

[WebKit Review Bot]

Attachment 64898 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:2125:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nat Duca]

Created attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

[Adam Barth]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Looks reasonable to me, but I'm not an expert in this area.

[Vangelis Kokkevis]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Looks good on my side too. cq+ from me.

[WebKit Commit Bot]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Rejecting patch 64903 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Vangelis Kokkevis]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

One more try to get it to the commit queue.

[Vangelis Kokkevis]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

with the flag set correctly this time :)

[WebKit Commit Bot]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Rejecting patch 64903 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 64903 [details]
Trying again. Not my day for patch files, it seems.

Clearing flags on attachment: 64903

Committed r66450: <http://trac.webkit.org/changeset/66450>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.