Bug 44186 – Web Inspector: introduce runtime agent for evaluation on window.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 64728 [details]
[PATCH] Proposed change (will patch xcode project upon landing)

This is one of the steps that move us away from broad InjectedScript API that can not be formalized on the idl into the thinner one on InspecotrBackend. I plan to 'inject' rest of the functions from the front-end be means of evaluateOnSelf-alike method.

[Ilya Tikhonovsky]

please rebase the patch

[Ilya Tikhonovsky]

Comment on attachment 64728 [details]
[PATCH] Proposed change (will patch xcode project upon landing)

WebCore/inspector/InspectorRuntimeAgent.cpp:49
 +      , m_remoteFrontend(remoteFrontend)
m_remoteFrontend is not used in the code.

WebCore/inspector/InspectorRuntimeAgent.cpp:101
 +      injectedScript.getPrototypes(nodeId, result, success);
success flag and hadException argument of injectedScript.getPrototypes have the opposit meaning.

[Pavel Feldman]

Created attachment 64855 [details]
[PATCH] Review comments addressed.

Thanks for review Ilya!

[Eric Seidel (no email)]

Attachment 64855 [details] did not build on mac:
Build output: http://queues.webkit.org/results/3769410

[Yury Semikhatsky]

Comment on attachment 64855 [details]
[PATCH] Review comments addressed.

WebCore/inspector/front-end/ObjectPropertiesSection.js:53
 +          this.object.getProperties(!this.ignoreHasOwnProperty, true, callback);
Let's rename ignoreHasOwnProperty too.

[Sam Weinig]

The changelog does not address the change to the license. Is that a related change? What is it about?

[Yury Semikhatsky]

Clearing r? flag as it was decided to rework this approach a bit.

[Pavel Feldman]

(In reply to comment #7)
> The changelog does not address the change to the license. Is that a related change? What is it about?

I was adding a new InspectorRuntimeAgent and I copy-pasted a license from InspectoStorageAgent I added earlier. At that point I noticed that I was accidentally using wrong license file there. So this includes a drive-by fix. Do you think it might be a problem?

[Rob Colburn]

Pavel,

Old bug, did you get through the legal issues?