RESOLVED FIXED Bug 44184
CanvasStyle method naming cleanup 
https://bugs.webkit.org/show_bug.cgi?id=44184
Summary CanvasStyle method naming cleanup
Andreas Kling
Reported 2010-08-18 10:04:20 PDT
As suggested by Darin on bug 43718, the CanvasStyle::create() overloads should be renamed to reflect what they're constructing the CanvasStyle objects from. The same goes for isEquivalentColor() overloads.
Attachments
Proposed patch (14.53 KB, patch)
2010-08-18 10:08 PDT, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-08-18 10:08:42 PDT
Created attachment 64722 [details] Proposed patch
Darin Adler
Comment 2 2010-08-18 10:21:34 PDT
Comment on attachment 64722 [details] Proposed patch > + static PassRefPtr<CanvasStyle> createFromGradient(PassRefPtr<CanvasGradient> gradient); > + static PassRefPtr<CanvasStyle> createFromPattern(PassRefPtr<CanvasPattern> pattern); No need for argument names in these two functions, since the type already expresses the name of the argument.
Andreas Kling
Comment 3 2010-08-18 10:28:44 PDT
Committed r65613: <http://trac.webkit.org/changeset/65613>
WebKit Review Bot
Comment 4 2010-08-18 10:56:48 PDT
http://trac.webkit.org/changeset/65613 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.