Bug 44184 - CanvasStyle method naming cleanup
Summary: CanvasStyle method naming cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 10:04 PDT by Andreas Kling
Modified: 2010-08-18 10:56 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (14.53 KB, patch)
2010-08-18 10:08 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2010-08-18 10:04:20 PDT 
As suggested by Darin on bug 43718, the CanvasStyle::create() overloads should be renamed to reflect what they're constructing the CanvasStyle objects from. The same goes for isEquivalentColor() overloads.
Comment 1 Andreas Kling 2010-08-18 10:08:42 PDT 
Created attachment 64722 [details]
Proposed patch
Comment 2 Darin Adler 2010-08-18 10:21:34 PDT 
Comment on attachment 64722 [details]
Proposed patch

> +        static PassRefPtr<CanvasStyle> createFromGradient(PassRefPtr<CanvasGradient> gradient);
> +        static PassRefPtr<CanvasStyle> createFromPattern(PassRefPtr<CanvasPattern> pattern);

No need for argument names in these two functions, since the type already expresses the name of the argument.
Comment 3 Andreas Kling 2010-08-18 10:28:44 PDT 
Committed r65613: <http://trac.webkit.org/changeset/65613>
Comment 4 WebKit Review Bot 2010-08-18 10:56:48 PDT 
http://trac.webkit.org/changeset/65613 might have broken SnowLeopard Intel Release (Tests)