Bug 44171 – Web Inspector: expose Panel.onSelectionChanged in extension API

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

onSelectionChanged was accidentally implemented on PanelImpl rather than Panel, hence not visible to the client.

[Andrey Kosyakov]

Created attachment 64702 [details]
patch

[WebKit Commit Bot]

Comment on attachment 64702 [details]
patch

Rejecting patch 64702 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Running build-dumprendertree
Compiling Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Testing 20868 test cases.
inspector/extensions.html -> failed

Exiting early after 1 failures. 16931 tests run.
312.82s total testing time

16930 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
33 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3796037

[Andrey Kosyakov]

Created attachment 64736 [details]
patch

rebased failed test.

[WebKit Commit Bot]

Comment on attachment 64736 [details]
patch

Rejecting patch 64736 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 64736, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=64736&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=44171&ctype=xml
Processing 1 patch from 1 bug.
Cleaning working directory
Processing patch 64736 from bug 44171.
ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

[Andrey Kosyakov]

Created attachment 64838 [details]
patch

[WebKit Commit Bot]

Comment on attachment 64838 [details]
patch

Clearing flags on attachment: 64838

Committed r65672: <http://trac.webkit.org/changeset/65672>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Andrey, are you aware that this broke GTK's tests?
<http://webkit.org/b/44342> [GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing

I don't know what would have broken GTK. Your patch looks good to me.

[Joseph Pecoraro]

> I don't know what would have broken GTK. Your patch looks good to me.

I debugged this a bit with mrobinson. He said it was was something different.
GTK is using stale files. Sorry for the false alarm!