Bug 44160 - Web Inspector: make objectId of string type instead of object.
Summary: Web Inspector: make objectId of string type instead of object.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-18 02:42 PDT by Pavel Feldman
Modified: 2010-08-18 09:43 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Proposed change. (7.14 KB, patch)
2010-08-18 03:01 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2010-08-18 02:42:16 PDT 
We'd like objectId to be 'string' on the protocol level. Patch to follow.
Comment 1 Pavel Feldman 2010-08-18 03:01:35 PDT 
Created attachment 64679 [details]
[PATCH] Proposed change.
Comment 2 Pavel Feldman 2010-08-18 03:09:39 PDT 
Comment on attachment 64679 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 64679

Committed r65597: <http://trac.webkit.org/changeset/65597>
Comment 3 Pavel Feldman 2010-08-18 03:09:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2010-08-18 03:28:30 PDT 
http://trac.webkit.org/changeset/65597 might have broken Qt Windows 32-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/65594
http://trac.webkit.org/changeset/65595
http://trac.webkit.org/changeset/65596
http://trac.webkit.org/changeset/65597
Comment 5 Joseph Pecoraro 2010-08-18 09:43:54 PDT 
Comment on attachment 64679 [details]
[PATCH] Proposed change.

> +        parsedObjectId.id = parseInt(tokens[1]);
> +    return InjectedScriptAccess.get(parseInt(tokens[0]));

I am always wary of parseInt() calls without a radix. Especially
when user input may be involved. But I guess it is okay here.
Just something to keep in mind.