RESOLVED FIXED 44160
Web Inspector: make objectId of string type instead of object. 
https://bugs.webkit.org/show_bug.cgi?id=44160
Summary Web Inspector: make objectId of string type instead of object.
Pavel Feldman
Reported Wednesday, August 18, 2010 10:42:16 AM UTC
We'd like objectId to be 'string' on the protocol level. Patch to follow.
Attachments
[PATCH] Proposed change. (7.14 KB, patch)
2010-08-18 03:01 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 Wednesday, August 18, 2010 11:01:35 AM UTC
Created attachment 64679 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 2 Wednesday, August 18, 2010 11:09:39 AM UTC
Comment on attachment 64679 [details] [PATCH] Proposed change. Clearing flags on attachment: 64679 Committed r65597: <http://trac.webkit.org/changeset/65597>
Pavel Feldman
Comment 3 Wednesday, August 18, 2010 11:09:49 AM UTC
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 Wednesday, August 18, 2010 11:28:30 AM UTC
http://trac.webkit.org/changeset/65597 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597
Joseph Pecoraro
Comment 5 Wednesday, August 18, 2010 5:43:54 PM UTC
Comment on attachment 64679 [details] [PATCH] Proposed change. > + parsedObjectId.id = parseInt(tokens[1]); > + return InjectedScriptAccess.get(parseInt(tokens[0])); I am always wary of parseInt() calls without a radix. Especially when user input may be involved. But I guess it is okay here. Just something to keep in mind.
Note You need to log in before you can comment on or make changes to this bug.