Bug 44157 - [GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
Summary: [GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 41512 (view as bug list)
Depends on: 44158
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-18 02:13 PDT by Philippe Normand
Modified: 2010-12-06 13:38 PST (History)
0 users

See Also:

Attachments
proposed patch (2.50 KB, patch)
2010-08-18 03:22 PDT, Philippe Normand 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2010-08-18 02:13:56 PDT 
We should replace the platform-specific calls to pause/unpause the download with use of ResourceHandle::setDefersLoading
Comment 1 Philippe Normand 2010-08-18 02:19:07 PDT 
*** Bug 41512 has been marked as a duplicate of this bug. ***
Comment 2 Philippe Normand 2010-08-18 03:22:15 PDT 
Created attachment 64682 [details]
proposed patch
Comment 3 Martin Robinson 2010-08-23 08:40:33 PDT 
Comment on attachment 64682 [details]
proposed patch

LGTM! Be sure to land after deferred loading lands in the soup backend.
Comment 4 Philippe Normand 2010-08-31 01:58:56 PDT 
(In reply to comment #3)
> (From update of attachment 64682 [details])
> LGTM! Be sure to land after deferred loading lands in the soup backend.

Feel free to clear the r+ flag for now. Trying to land the patch from bug 44158 is counter-productive as it'd need work again after the SoupURILoader code lands from bug 44261
Comment 5 Philippe Normand 2010-09-02 00:11:09 PDT 
Comment on attachment 64682 [details]
proposed patch

Clearing r+ flag as per comment 4
Comment 6 Martin Robinson 2010-11-23 08:49:17 PST 
Comment on attachment 64682 [details]
proposed patch

Gogogogo!
Comment 7 Philippe Normand 2010-12-06 13:38:18 PST 
Committed r73396: <http://trac.webkit.org/changeset/73396>