RESOLVED FIXED 44151
ASSERT(!m_database->sqliteDatabase().transactionInProgress()); can fail 
https://bugs.webkit.org/show_bug.cgi?id=44151
Summary ASSERT(!m_database->sqliteDatabase().transactionInProgress()); can fail
Adam Barth
Reported 2010-08-17 22:28:54 PDT
http://trac.webkit.org/browser/trunk/WebCore/storage/SQLTransaction.cpp#L276 // Transaction Steps 3 - Peform preflight steps, jumping to the error callback if they fail if (m_wrapper && !m_wrapper->performPreflight(this)) { ASSERT(!m_database->sqliteDatabase().transactionInProgress()); m_sqliteTransaction.clear(); m_transactionError = m_wrapper->sqlError(); if (!m_transactionError) m_transactionError = SQLError::create(SQLError::UNKNOWN_ERR, "unknown error occured setting up transaction"); handleTransactionError(false); return; }
Attachments
patch (3.90 KB, patch)
2010-08-20 13:34 PDT, Dumitru Daniliuc 		abarth: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-08-20 12:25:57 PDT
Looking. I'm assuming this was discovered by the same fuzzer?
Adam Barth
Comment 2 2010-08-20 12:37:42 PDT
Yep.
Dumitru Daniliuc
Comment 3 2010-08-20 13:34:00 PDT
Created attachment 64985 [details] patch
Adam Barth
Comment 4 2010-08-20 13:54:51 PDT
Comment on attachment 64985 [details] patch ok
Dumitru Daniliuc
Comment 5 2010-08-20 14:54:34 PDT
landed: r65755.
Note You need to log in before you can comment on or make changes to this bug.