Bug 44147 - [EFL] enable libsoup's content decode feature
Summary: [EFL] enable libsoup's content decode feature
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 19:04 PDT by Jaehun Lim
Modified: 2012-10-10 02:58 PDT (History)
5 users (show)

See Also:


Attachments
error screen (22.12 KB, image/png)
2010-08-17 19:16 PDT, Jaehun Lim
no flags Details
Patch (1.03 KB, patch)
2010-08-17 19:17 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff
Enable libsoup's content decode feature (1.08 KB, patch)
2010-08-17 22:21 PDT, Jaehun Lim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaehun Lim 2010-08-17 19:04:32 PDT
WebKit-EFL does not support some gzip encoded contents.

See attached error screen.

Test site is mobile twitter login page. (https://mobile.twitter.com/session/new/)
 - CSS is not applied.
Comment 1 Jaehun Lim 2010-08-17 19:16:14 PDT
Created attachment 64660 [details]
error screen
Comment 2 Jaehun Lim 2010-08-17 19:17:57 PDT
Created attachment 64661 [details]
Patch
Comment 3 Antonio Gomes 2010-08-17 21:42:24 PDT
Comment on attachment 64661 [details]
Patch

r=me

> +        [EFL] enable libsoup's content decode feature
> +        https://bugs.webkit.org/show_bug.cgi?id=44147
> +
> +        libsoup's content decode feature is enabled during initializaton.

Please, rephrase to something like: "Enable libsoup's content decode feature..." or "Make libsoup's content decode feature is enabled during initializaton to fix web sites that send CSS encoded", blablabla. Something more descriptive.

ps: When uploading the new patch , fill "Reviewed by" statement in the ChangeLog with "Antonio Gomes" and just set "cq?" to the patch. No need for a new 

> --- a/WebKit/efl/ewk/ewk_main.cpp
> +++ b/WebKit/efl/ewk/ewk_main.cpp
> @@ -125,6 +125,7 @@ int ewk_init(void)
>      if (1) {
>          SoupSession* session = WebCore::ResourceHandle::defaultSession();
>          soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_SNIFFER);
> +        soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
>      }
>  #endif  

the if (1) above made me sad! :-(
Comment 4 Jaehun Lim 2010-08-17 22:21:13 PDT
Created attachment 64670 [details]
Enable libsoup's content decode feature

OK. I upload a new patch.

Thanks for your review.
Comment 5 Lucas De Marchi 2010-08-25 13:28:10 PDT
Comment on attachment 64661 [details]
Patch

Clearing flags on attachment: 64661

Committed r66038: <http://trac.webkit.org/changeset/66038>
Comment 6 Lucas De Marchi 2010-08-25 13:28:20 PDT
All reviewed patches have been landed.  Closing bug.