RESOLVED FIXED 44143
new-run-webkit-tests: remove --show-sources option 
https://bugs.webkit.org/show_bug.cgi?id=44143
Summary new-run-webkit-tests: remove --show-sources option
Dirk Pranke
Reported 2010-08-17 17:06:44 PDT
new-run-webkit-tests: remove --show-sources option
Attachments
Patch (7.34 KB, patch)
2010-08-17 17:09 PDT, Dirk Pranke 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-08-17 17:09:44 PDT
Created attachment 64655 [details] Patch
David Levin
Comment 2 2010-08-17 17:27:56 PDT
Comment on attachment 64655 [details] Patch > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py b/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py > + return port.compare_text(self._get_normalized_text(file1), > + self._get_normalized_text(file2)) Consider fixing the alignment here.
Dirk Pranke
Comment 3 2010-08-17 17:30:16 PDT
(In reply to comment #2) > (From update of attachment 64655 [details]) > > > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py b/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py > > + return port.compare_text(self._get_normalized_text(file1), > > + self._get_normalized_text(file2)) > Consider fixing the alignment here. will do. thanks!
Dirk Pranke
Comment 4 2010-08-17 17:59:59 PDT
Committed r65578: <http://trac.webkit.org/changeset/65578>
Note You need to log in before you can comment on or make changes to this bug.