Bug 44130 - Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS).
Summary: Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 14:06 PDT by Stephen White
Modified: 2010-08-17 16:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2010-08-17 14:07 PDT, Stephen White 		levin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2010-08-17 14:06:36 PDT 
Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS).
Comment 1 Stephen White 2010-08-17 14:07:58 PDT 
Created attachment 64629 [details]
Patch
Comment 2 James Robinson 2010-08-17 14:15:35 PDT 
Seems OK.
Comment 3 David Levin 2010-08-17 15:25:56 PDT 
Comment on attachment 64629 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 65540)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,23 @@
> +2010-08-17  Stephen White  <senorblanco@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS).
> +
> +        No tests; if it compiles, it's good.
> +
> +        * html/canvas/CanvasRenderingContext2D.cpp:
> +        (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
> +        Fix a warning (treated as error).

Fixed the warning that rootView wasn't used.

(It took me a minute to figure out what you were fixing.)
Comment 4 Stephen White 2010-08-17 16:00:44 PDT 
Committed r65569: <http://trac.webkit.org/changeset/65569>