Bug 44095 - [GTK] Fix wrapping of core Events in the bindings
Summary: [GTK] Fix wrapping of core Events in the bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-17 02:32 PDT by Xan Lopez
Modified: 2010-08-17 05:25 PDT (History)
0 users

See Also:

Attachments
wrapevents.diff (3.20 KB, patch)
2010-08-17 02:35 PDT, Xan Lopez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-08-17 02:32:58 PDT 
We were mistakenly wrapping any Event or subclass as a WebKitDOMEvent, but we need to return the proper GObject type whenever appropriate (ie, a WebKitDOMMouseEvent for MouseEvent).
Comment 1 Xan Lopez 2010-08-17 02:35:10 PDT 
Created attachment 64567 [details]
wrapevents.diff

Patch.
Comment 2 Gustavo Noronha (kov) 2010-08-17 05:16:35 PDT 
Comment on attachment 64567 [details]
wrapevents.diff

OK!
Comment 3 Xan Lopez 2010-08-17 05:25:20 PDT 
Comment on attachment 64567 [details]
wrapevents.diff

Landed in r65497.
Comment 4 Xan Lopez 2010-08-17 05:25:37 PDT 
Closing bug.