Bug 44094 - [Qt] Short lived shadow buffer for blur operation
Summary: [Qt] Short lived shadow buffer for blur operation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords: HTML5, Qt, QtTriaged
Depends on:
Blocks: 34479
  Show dependency tree / graph
 
Reported: 2010-08-17 01:11 PDT by Ariya Hidayat
Modified: 2010-08-18 23:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2010-08-18 16:08 PDT, Ariya Hidayat 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-08-17 01:11:04 PDT 
Everytime we need blur shadow, we create and destroy QImage for the scratch buffer. Technically we do not need to do this, we can keep a persistent buffer which has a limited life time so that successive blur will just reuse the same buffer.
Comment 1 Ariya Hidayat 2010-08-18 16:08:09 PDT 
Created attachment 64784 [details]
Patch
Comment 2 Andreas Kling 2010-08-18 16:20:10 PDT 
Comment on attachment 64784 [details]
Patch

(Informal) LGTM :)
Comment 3 Kenneth Rohde Christiansen 2010-08-18 22:45:27 PDT 
Comment on attachment 64784 [details]
Patch

Making it formal :-) r=me

WebCore/ChangeLog:10
 +          we create a buffer which will be automatically purged via a timer.
Maybe this description would be nice to have in the class?
Comment 4 Ariya Hidayat 2010-08-18 23:21:56 PDT 
Committed r65654: <http://trac.webkit.org/changeset/65654>
Comment 5 WebKit Review Bot 2010-08-18 23:39:39 PDT 
http://trac.webkit.org/changeset/65654 might have broken SnowLeopard Intel Release (Tests)