RESOLVED FIXED Bug 44070
REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium 
https://bugs.webkit.org/show_bug.cgi?id=44070
Summary REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-0...
Ryosuke Niwa
Reported 2010-08-16 13:45:59 PDT
This is a regression due to http://trac.webkit.org/changeset/65208. editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium.
Attachments
fixes the crash (4.10 KB, patch)
2010-08-16 14:02 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
added a test that works on Mac (6.83 KB, patch)
2010-08-16 15:49 PDT, Ryosuke Niwa 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2010-08-16 13:46:23 PDT
http://crbug.com/52014.
Ryosuke Niwa
Comment 2 2010-08-16 14:02:16 PDT
Created attachment 64518 [details] fixes the crash
Tony Chang
Comment 3 2010-08-16 14:06:40 PDT
Why does this only crash on Chromium Win? Is it possible to write a layout test that crashes on WebKit mac that we can add?
Ryosuke Niwa
Comment 4 2010-08-16 14:13:24 PDT
(In reply to comment #3) > Why does this only crash on Chromium Win? Is it possible to write a layout test that crashes on WebKit mac that we can add? I tried many obscure cases to reproduce the issue but only reproduces in Chromium Windows. I'm not sure if it only crashes on Chromium Windows. It's quite possible that it also crashes on WebKit Win. I suspect that our implementation of selection is slightly different on Windows, and somehow obtaining a different selection.
Tony Chang
Comment 5 2010-08-16 14:28:22 PDT
(In reply to comment #4) > I tried many obscure cases to reproduce the issue but only reproduces in Chromium Windows. I'm not sure if it only crashes on Chromium Windows. It's quite possible that it also crashes on WebKit Win. I suspect that our implementation of selection is slightly different on Windows, and somehow obtaining a different selection. Since these are testing smart-paste, it probably has to do with inserting extra spaces. Maybe layoutTestController.setSmartInsertDeleteEnabled() can help repro this on a mac?
Ryosuke Niwa
Comment 6 2010-08-16 15:49:06 PDT
Created attachment 64529 [details] added a test that works on Mac
Ryosuke Niwa
Comment 7 2010-08-16 16:23:22 PDT
Committed r65467: <http://trac.webkit.org/changeset/65467>
Note You need to log in before you can comment on or make changes to this bug.