Bug 44070 - REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
Summary: REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-0...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P1 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-16 13:45 PDT by Ryosuke Niwa
Modified: 2010-08-16 16:23 PDT (History)
3 users (show)

See Also:

Attachments
fixes the crash (4.10 KB, patch)
2010-08-16 14:02 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
added a test that works on Mac (6.83 KB, patch)
2010-08-16 15:49 PDT, Ryosuke Niwa 		tony: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2010-08-16 13:45:59 PDT 
This is a regression due to http://trac.webkit.org/changeset/65208. editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium.
Comment 1 Ryosuke Niwa 2010-08-16 13:46:23 PDT 
http://crbug.com/52014.
Comment 2 Ryosuke Niwa 2010-08-16 14:02:16 PDT 
Created attachment 64518 [details]
fixes the crash
Comment 3 Tony Chang 2010-08-16 14:06:40 PDT 
Why does this only crash on Chromium Win?  Is it possible to write a layout test that crashes on WebKit mac that we can add?
Comment 4 Ryosuke Niwa 2010-08-16 14:13:24 PDT 
(In reply to comment #3)
> Why does this only crash on Chromium Win?  Is it possible to write a layout test that crashes on WebKit mac that we can add?

I tried many obscure cases to reproduce the issue but only reproduces in Chromium Windows.  I'm not sure if it only crashes on Chromium Windows.  It's quite possible that it also crashes on WebKit Win.  I suspect that our implementation of selection is slightly different on Windows, and somehow obtaining a different selection.
Comment 5 Tony Chang 2010-08-16 14:28:22 PDT 
(In reply to comment #4)
> I tried many obscure cases to reproduce the issue but only reproduces in Chromium Windows.  I'm not sure if it only crashes on Chromium Windows.  It's quite possible that it also crashes on WebKit Win.  I suspect that our implementation of selection is slightly different on Windows, and somehow obtaining a different selection.

Since these are testing smart-paste, it probably has to do with inserting extra spaces.  Maybe layoutTestController.setSmartInsertDeleteEnabled() can help repro this on a mac?
Comment 6 Ryosuke Niwa 2010-08-16 15:49:06 PDT 
Created attachment 64529 [details]
added a test that works on Mac
Comment 7 Ryosuke Niwa 2010-08-16 16:23:22 PDT 
Committed r65467: <http://trac.webkit.org/changeset/65467>