Bug 44068 - [Qt] tests whose bug was closed but are still skipped
Summary: [Qt] tests whose bug was closed but are still skipped
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-16 12:44 PDT by Ademar Reis
Modified: 2010-08-17 01:55 PDT (History)
1 user (show)

See Also:

Attachments
Enable tests whose bug is fixed (3.45 KB, patch)
2010-08-16 13:00 PDT, Ademar Reis 		no flags Details | Formatted Diff | Diff
Enable tests whose bug is fixed (3.38 KB, patch)
2010-08-16 13:26 PDT, Ademar Reis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ademar Reis 2010-08-16 12:44:04 PDT 
There are a few outdated entries inside platform/qt/Skipped pointing to bugs already fixed.

They are:

bug #36628
bug #35350
bug #28952
bug #38502 (see discussion at the end)
bug #38604

As a result the following tests should be enabled:

editing/selection/shrink-selection-after-shift-pagedown.html
fast/workers/worker-multi-port.html
fast/workers/worker-context-multi-port.html
fast/workers/worker-event-listener.html
fast/events/show-modal-dialog-onblur-onfocus.html
fast/harness/show-modal-dialog.html
Comment 1 Ademar Reis 2010-08-16 12:52:08 PDT 
My mistake, bug #36628 is not closed (but it should be, IMO).

I'll handle the editing/selection/shrink-selection-after-shift-pagedown.html testcase there and close the bug. The others remain valid.
Comment 2 Ademar Reis 2010-08-16 13:00:30 PDT 
Created attachment 64511 [details]
Enable tests whose bug is fixed
Comment 3 Ademar Reis 2010-08-16 13:26:45 PDT 
Created attachment 64514 [details]
Enable tests whose bug is fixed

patch v2, formating it to avoid ChangeLog dependency from my previous patches.

Sorry for spamming, /me new to webkit-devel :)
Comment 4 Ariya Hidayat 2010-08-17 01:38:08 PDT 
Comment on attachment 64514 [details]
Enable tests whose bug is fixed

LGTM, re=me
Comment 5 WebKit Commit Bot 2010-08-17 01:55:41 PDT 
Comment on attachment 64514 [details]
Enable tests whose bug is fixed

Clearing flags on attachment: 64514

Committed r65489: <http://trac.webkit.org/changeset/65489>
Comment 6 WebKit Commit Bot 2010-08-17 01:55:45 PDT 
All reviewed patches have been landed.  Closing bug.