Bug 44065 – Self inclusion in Document.h and RenderTheme.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ademar Reis]

WebCore/dom/Document.h
and
WebCore/rendering/RenderTheme.h

both include themselves.

[Ademar Reis]

Created attachment 64506 [details]
Fix for self inclusion

trivial fix

[WebKit Commit Bot]

Comment on attachment 64506 [details]
Fix for self inclusion

Rejecting patch 64506 from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 64506 [details]
Fix for self inclusion

Rejecting patch 64506 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact [e-mail] to request a commit-queue restart.  After restart the commit-queue will correctly respect your committer rights.

[Ademar Reis]

Created attachment 64507 [details]
Fix for self inclusion

trivial fix

[WebKit Commit Bot]

Comment on attachment 64507 [details]
Fix for self inclusion

Rejecting patch 64507 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1
Last 500 characters of output:
ue/LayoutTests
Testing 20850 test cases.
media/video-currentTime-set.html -> timed out
Sampling process 15922 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 15922 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 17197 tests run.
746.42s total testing time

17196 test cases (99%) succeeded
1 test case (<1%) timed out
34 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/3708270

[Ademar Reis]

I can't understand how a trivial fix for double header inclusion could trigger a failure on the media/video-currentTime-set.html test.

I guess this is a hiccup on the mac build-bot... What should I do now?

[Eric Seidel (no email)]

I believe this is some CoreVideo bug on Leopard.  I need to move the commit-queue to snow leopard since this bug is unlikely to ever get fixed.  Basically the media and compositing tests randomly crash or hang on certain leopard machines.  The commit-queue happens to be one such machine. :(

[WebKit Commit Bot]

Comment on attachment 64507 [details]
Fix for self inclusion

Clearing flags on attachment: 64507

Committed r65504: <http://trac.webkit.org/changeset/65504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.