Bug 44056 - [GTK] GSettings support adds annoying warnings on systems with older glib versions
Summary: [GTK] GSettings support adds annoying warnings on systems with older glib ver...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2010-08-16 07:23 PDT by Gustavo Noronha (kov)
Modified: 2010-08-17 06:10 PDT (History)
1 user (show)

See Also:


Attachments
proposed fix (8.00 KB, patch)
2010-08-16 07:24 PDT, Gustavo Noronha (kov)
mrobinson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-08-16 07:23:53 PDT
I would just commit this patch, but thought it might be a better idea to use the EWS as a try bot instead of spending more time building an environment to test it against.
Comment 1 Gustavo Noronha (kov) 2010-08-16 07:24:22 PDT
Created attachment 64493 [details]
proposed fix
Comment 2 Martin Robinson 2010-08-16 09:04:29 PDT
Comment on attachment 64493 [details]
proposed fix

I'm not sure if this review is necessary, but the EWS is green so LGTM!
Comment 3 Gustavo Noronha (kov) 2010-08-16 09:54:26 PDT
Comment on attachment 64493 [details]
proposed fix

\o/
Comment 4 WebKit Commit Bot 2010-08-16 11:44:12 PDT
Comment on attachment 64493 [details]
proposed fix

Rejecting patch 64493 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 2
Last 500 characters of output:
ChangeLog
patching file WebKit/gtk/ChangeLog
patching file WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
patching file WebKit/gtk/webkit/webkitprivate.cpp
patching file WebKit/gtk/webkit/webkitprivate.h
patching file autotools/gsettings.m4
The following paths are ignored by one of your .gitignore files:
autotools
Use -f if you really want to add them.
fatal: no files added
Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427.

Full output: http://queues.webkit.org/results/3718273
Comment 5 Gustavo Noronha (kov) 2010-08-17 05:59:17 PDT
(In reply to comment #4)
> patching file autotools/gsettings.m4
> The following paths are ignored by one of your .gitignore files:
> autotools
> Use -f if you really want to add them.
> fatal: no files added
> Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427.
> 
> Full output: http://queues.webkit.org/results/3718273

That's because .gitignore is casting the net too wide (ignoring the whole autotools directory). I'll make it more selective so this doesn't happen again =).
Comment 6 Gustavo Noronha (kov) 2010-08-17 06:10:27 PDT
Landed as r65498, thanks!