Bug 44056 – [GTK] GSettings support adds annoying warnings on systems with older glib versions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

I would just commit this patch, but thought it might be a better idea to use the EWS as a try bot instead of spending more time building an environment to test it against.

[Gustavo Noronha (kov)]

Created attachment 64493 [details]
proposed fix

[Martin Robinson]

Comment on attachment 64493 [details]
proposed fix

I'm not sure if this review is necessary, but the EWS is green so LGTM!

[Gustavo Noronha (kov)]

Comment on attachment 64493 [details]
proposed fix

\o/

[WebKit Commit Bot]

Comment on attachment 64493 [details]
proposed fix

Rejecting patch 64493 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 2
Last 500 characters of output:
ChangeLog
patching file WebKit/gtk/ChangeLog
patching file WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
patching file WebKit/gtk/webkit/webkitprivate.cpp
patching file WebKit/gtk/webkit/webkitprivate.h
patching file autotools/gsettings.m4
The following paths are ignored by one of your .gitignore files:
autotools
Use -f if you really want to add them.
fatal: no files added
Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427.

Full output: http://queues.webkit.org/results/3718273

[Gustavo Noronha (kov)]

(In reply to comment #4)
> patching file autotools/gsettings.m4
> The following paths are ignored by one of your .gitignore files:
> autotools
> Use -f if you really want to add them.
> fatal: no files added
> Failed to git add autotools/gsettings.m4. at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 427.
> 
> Full output: http://queues.webkit.org/results/3718273

That's because .gitignore is casting the net too wide (ignoring the whole autotools directory). I'll make it more selective so this doesn't happen again =).

[Gustavo Noronha (kov)]

Landed as r65498, thanks!