WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
4405
<button> not listed in form collections.
https://bugs.webkit.org/show_bug.cgi?id=4405
Summary
<button> not listed in form collections.
Maks Orlovich
Reported
2005-08-12 08:58:36 PDT
Hi.. Looks like you folks also have the KDE
bug #110629
, <button> not included in form elements collection. Will attach testcase and the obvious patch (against kde svn, don't have a mac)
Attachments
Testcase
(684 bytes, text/html)
2005-08-12 08:59 PDT
,
Maks Orlovich
no flags
Details
Maks's fix in patch form, with test case
(4.82 KB, patch)
2005-12-27 04:01 PST
,
Maciej Stachowiak
mjs
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Maks Orlovich
Comment 1
2005-08-12 08:59:44 PDT
Created
attachment 3353
[details]
Testcase Testcase (khtmltests/regression/tests/ecma/form-collect-button-110629.html) FFox, WinIE, and MacIE all find the <button>
Maks Orlovich
Comment 2
2005-08-12 09:00:54 PDT
The following obvious change fixes it: maksim@treetop khtml]$ ~/kde3/kdesdk/scripts/svnlastchange html/html_formimpl.h ------------------------------------------------------------------------
r446120
| orlovich | 2005-08-12 11:31:46 -0400 (Fri, 12 Aug 2005) | 4 lines <button> belongs in form collections, too. Testcase based on the report upcoming. BUG:110629 ------------------------------------------------------------------------ Index: html/html_formimpl.h =================================================================== --- html/html_formimpl.h (revision 446119) +++ html/html_formimpl.h (revision 446120) @@ -196,6 +196,7 @@ public: }; virtual Id id() const; + virtual bool isEnumeratable() const { return true; } DOMString type() const; typeEnum buttonType() const { return m_type; }
Maciej Stachowiak
Comment 3
2005-12-27 04:01:46 PST
Created
attachment 5298
[details]
Maks's fix in patch form, with test case
Maciej Stachowiak
Comment 4
2005-12-27 04:02:27 PST
Comment on
attachment 5298
[details]
Maks's fix in patch form, with test case r=me on Maks's fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug