Bug 44041 - ProcessLauncher's WorkQueue's name is too long on Windows
Summary: ProcessLauncher's WorkQueue's name is too long on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Dominik Röttsches (drott)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 17:53 PDT by Jon Honeycutt
Modified: 2012-07-06 07:50 PDT (History)
4 users (show)

See Also:


Attachments
Shortening ProcessLauncher thread name. (1.73 KB, patch)
2012-07-06 05:34 PDT, Dominik Röttsches (drott)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Honeycutt 2010-08-15 17:53:56 PDT
The WorkQueue used by ProcessLauncher has the name "com.apple.WebKit.ProcessLauncher". This results in stderr output when running layout tests:

ERROR: Thread name "com.apple.WebKit.ProcessLauncher" is longer than 31 characters and will be truncated by Visual Studio
(..\..\wtf\Threading.cpp:74 WTF::createThread)
Comment 1 Dominik Röttsches (drott) 2012-07-06 05:34:46 PDT
Created attachment 151064 [details]
Shortening ProcessLauncher thread name.
Comment 2 Andreas Kling 2012-07-06 05:36:52 PDT
Comment on attachment 151064 [details]
Shortening ProcessLauncher thread name.

This seems like a reasonable thing to do.
rs=me
Comment 3 WebKit Review Bot 2012-07-06 07:50:08 PDT
Comment on attachment 151064 [details]
Shortening ProcessLauncher thread name.

Clearing flags on attachment: 151064

Committed r121972: <http://trac.webkit.org/changeset/121972>
Comment 4 WebKit Review Bot 2012-07-06 07:50:13 PDT
All reviewed patches have been landed.  Closing bug.