Bug 44038 - HTML5 fragment parsing doesn't load iframes
Summary: HTML5 fragment parsing doesn't load iframes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 14:27 PDT by Adam Barth
Modified: 2010-08-16 07:20 PDT (History)
2 users (show)

See Also:

Attachments
reduced test case (140 bytes, text/html)
2010-08-15 14:27 PDT, Adam Barth 		no flags Details
Patch (3.76 KB, patch)
2010-08-15 22:14 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (3.76 KB, patch)
2010-08-16 00:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-08-15 14:27:19 PDT 
Created attachment 64454 [details]
reduced test case

This is causing some layout test failures with --html5-treebuilder turned on.  I've attached a reduction.
Comment 1 Adam Barth 2010-08-15 14:37:47 PDT 
The problem is that Document::adoptNode is calling setRemainsAliveOnRemovalFromTree and confusing the frame.  I think we're supposed to construct the fragment completely detached but somehow it's getting attached?
Comment 2 Eric Seidel (no email) 2010-08-15 20:49:03 PDT 
Fragments shouldn't get attached at all. I suspect we have a bug in HTMLConstructionSite.
Comment 3 Adam Barth 2010-08-15 22:14:27 PDT 
Created attachment 64465 [details]
Patch
Comment 4 Alexey Proskuryakov 2010-08-16 00:21:31 PDT 
Comment on attachment 64465 [details]
Patch

r=me

The test output doesn't really make it obvious that it's a pass. Did you intent to keep the numbered alerts in?
Comment 5 Adam Barth 2010-08-16 00:28:53 PDT 
Created attachment 64473 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2010-08-16 01:04:42 PDT 
Comment on attachment 64473 [details]
Patch for landing

Clearing flags on attachment: 64473

Committed r65396: <http://trac.webkit.org/changeset/65396>
Comment 7 WebKit Commit Bot 2010-08-16 01:04:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-08-16 07:20:43 PDT 
Comment on attachment 64473 [details]
Patch for landing

Thanks.  I agree the test output is a bit confusing. :)  But I've very glad for the bug fix!