Bug 44033 - Some http/tests/history tests now pass on Chromium after r65340
Summary: Some http/tests/history tests now pass on Chromium after r65340
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 10:03 PDT by Mihai Parparita
Modified: 2010-08-16 12:01 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.07 KB, patch)
2010-08-15 11:45 PDT, Mihai Parparita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-08-15 10:03:47 PDT
From the canary bot output:

Expected to fail, but passed: (5)
  http/tests/history/redirect-200-refresh-0-seconds.pl
  http/tests/history/redirect-js-location-replace-0-seconds.html
  http/tests/history/redirect-js-location-replace-2-seconds.html
  http/tests/history/redirect-js-location-replace-before-load.html
  http/tests/history/redirect-meta-refresh-0-seconds.html

See https://bugs.webkit.org/show_bug.cgi?id=42861#c32 for details as to why they pass now. These tests were initially added to the "fixable" list with http://crrev.com/8946, and then to the "ignore" list with http://crrev.com/9287, so there was a bug filed for them.
Comment 1 Mihai Parparita 2010-08-15 11:45:32 PDT
Created attachment 64451 [details]
Patch
Comment 2 Mihai Parparita 2010-08-15 11:49:36 PDT
Nate, as the gardener/reviewer, do you mind reviewing this?

(in the description I meant to say "so there _never_ was a bug filed for them")
Comment 3 Nate Chapin 2010-08-16 11:28:15 PDT
Comment on attachment 64451 [details]
Patch

Yay!
Comment 4 WebKit Commit Bot 2010-08-16 12:00:55 PDT
Comment on attachment 64451 [details]
Patch

Clearing flags on attachment: 64451

Committed r65444: <http://trac.webkit.org/changeset/65444>
Comment 5 WebKit Commit Bot 2010-08-16 12:01:01 PDT
All reviewed patches have been landed.  Closing bug.